[Filebeat] Improve ECS categorization field mappings for nginx module #17844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leehinman
added
enhancement
Filebeat
|
Pinging @elastic/siem (Team:SIEM) |
- access + event.kind + event.category + event.type + event.outcome + lowercase http.request.method + improve grok to not populate empty fields + related.ip + related.users - error + event.kind + event.category + event.outcome - ingress_controller + event.kind + event.category + event.type + event.outcome + lowercase http.request.method + improve grok to not populate empty fields + related.ip + related.users Closes elastic#16174
leehinman
force-pushed
the
16174_nginx_ecs_1.4
branch
from
efea78e
to
500fb47
Compare
andrewkroh
approved these changes
Apr 23, 2020
4 tasks
leehinman
added
v7.8.0
and removed
needs_backport
leehinman
added a commit
to leehinman/beats
that referenced
this pull request
Apr 23, 2020
…7844) - access + event.kind + event.category + event.type + event.outcome + lowercase http.request.method + improve grok to not populate empty fields + related.ip + related.users - error + event.kind + event.category + event.outcome - ingress_controller + event.kind + event.category + event.type + event.outcome + lowercase http.request.method + improve grok to not populate empty fields + related.ip + related.users Closes elastic#16174 (cherry picked from commit 93c3d15)
exekias
reviewed
Apr 27, 2020
Comment on lines
-9
to
+17
| "http.request.method": "GET", | ||
| "http.request.referrer": "-", | ||
| "http.request.method": "get", |
There was a problem hiding this comment.
This looks like a breaking change? GET is now lowercased, also referrer is now missing
There was a problem hiding this comment.
I'm fine with marking this as a breaking change.
Some background.
http.request.referrer is an ECS field and docs say "The field value must be normalized to lowercase for querying." So that is why the change to lowercase.
http.request.referrer isn't missing, the GROK pattern was changed so it is only filled in when nginx logs a referrer an actual referrer. "-" is the same as not present.
leehinman
added a commit
to leehinman/beats
that referenced
this pull request
Apr 27, 2020
PR elastic#17844 introduced the following changes: - http.request.method is now lowercase - http.request.referrer is only set when nginx provides a value This PR updates the CHANGELOG to report this as a breaking change.
1 task
leehinman
added a commit
that referenced
this pull request
Apr 29, 2020
…17940) - access + event.kind + event.category + event.type + event.outcome + lowercase http.request.method + improve grok to not populate empty fields + related.ip + related.users - error + event.kind + event.category + event.outcome - ingress_controller + event.kind + event.category + event.type + event.outcome + lowercase http.request.method + improve grok to not populate empty fields + related.ip + related.users Closes #16174 (cherry picked from commit 93c3d15)
leehinman
added a commit
that referenced
this pull request
Apr 29, 2020
PR #17844 introduced the following changes: - http.request.method is now lowercase - http.request.referrer is only set when nginx provides a value This PR updates the CHANGELOG to report this as a breaking change.
Merged
1 task
leehinman
added a commit
to leehinman/beats
that referenced
this pull request
Apr 29, 2020
…#18026) PR elastic#17844 introduced the following changes: - http.request.method is now lowercase - http.request.referrer is only set when nginx provides a value This PR updates the CHANGELOG to report this as a breaking change. (cherry picked from commit 0de9b67)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improves ECS categorization field mappings for nginx module. Specifically it adds:
Why is it important?
Improved ECS compliance improves use in SIEM application and makes comparing data across data sources easier.
Checklist
- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues
Closes #16174