[Heartbeat] Improved redirect support #14125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewvc
added
bug
enhancement
Heartbeat
Team:obs-ds-hosted-services
|
Pinging @elastic/uptime (:uptime) |
houndci-bot
reviewed
Oct 18, 2019
andrewvc
added
[zube]: In Progress
in progress
andrewvc
added
[zube]: In Review
review
bug
v7.6.0
and removed
bug
in progress
This was referenced Oct 18, 2019
ruflin
approved these changes
Oct 21, 2019
There was a problem hiding this comment.
Code LGTM.
The thing that took me a while to understand is what exactly an event with 2 redirects looks like
- with the code today
- with the changed code and redirects set to 0
- with the changed code and redirects set to 10
It would be nice if we do a breaking change (which sounds reasonable here) to at least have it super easy for users to understand how their event structure will exactly change with an example.
|
@ruflin Thanks for the review! I've updated the PR description to include the full list of removed fields when HTTP redirects are enabled. |
|
@andrewvc I was actually thinking of documentation for our users, something like https://www.elastic.co/guide/en/beats/libbeat/current/breaking-changes-7.4.html |
|
@andrewvc Not sure if you saw my last comment here: #14125 (comment) I think this is still needed in a follow up PR. |
|
@ruflin ah, I missed it, will add. |
andrewvc
added a commit
to andrewvc/beats
that referenced
this pull request
Jan 29, 2020
This patch better handles redirects in heartbeat. It takes a different tack than what was described in elastic#13146 . This PR is on the whole more pragmatic, accomplishing substantive change with undue complication of the schema and beats codebase. Changes in this patch: * Added http.response.redirects field. This is an array of URLs redirected to inclusive of the final destination, exclusive of the original * Utilize the host codepath, rather than the IP codepath for execution of the check, previously only used for proxies in heartbeat, for redirects. This simplifies the code, hides timing data that can be screwy with redirects (things like fine grained DNS resolution). This means that the following fields no longer appear with redirects enabled in the event: http.rtt.content.us, http.rtt.response_header.us, http.rtt.total.us, http.rtt.validate.us, http.rtt.write_request.us. * Default max_redirects: 0 instead of 10 The new default does make this a breaking change, however, we either need to break that setting and preserve the timing information for the common use case of someone checking a non-redirecting URL, or keeping it at 10 but losing the timing info. The third option would be to invest additional eng. effort here to track those numbers across reqs, but the benefit seems, minimal given that they are not displayed in the UI, only in dashboards. (cherry picked from commit 694dac8)
jorgemarey
pushed a commit
to jorgemarey/beats
that referenced
this pull request
Jun 8, 2020
This patch better handles redirects in heartbeat. It takes a different tack than what was described in elastic#13146 . This PR is on the whole more pragmatic, accomplishing substantive change with undue complication of the schema and beats codebase. Changes in this patch: * Added http.response.redirects field. This is an array of URLs redirected to inclusive of the final destination, exclusive of the original * Utilize the host codepath, rather than the IP codepath for execution of the check, previously only used for proxies in heartbeat, for redirects. This simplifies the code, hides timing data that can be screwy with redirects (things like fine grained DNS resolution). This means that the following fields no longer appear with redirects enabled in the event: http.rtt.content.us, http.rtt.response_header.us, http.rtt.total.us, http.rtt.validate.us, http.rtt.write_request.us. * Default max_redirects: 0 instead of 10 The new default does make this a breaking change, however, we either need to break that setting and preserve the timing information for the common use case of someone checking a non-redirecting URL, or keeping it at 10 but losing the timing info. The third option would be to invest additional eng. effort here to track those numbers across reqs, but the benefit seems, minimal given that they are not displayed in the UI, only in dashboards.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch better handles redirects in heartbeat. It takes a different tack than what was described in #13146 . This PR is on the whole more pragmatic, accomplishing substantive change with undue complication of the schema and beats codebase.
Changes in this patch:
http.response.redirectsfield. This is an array of URLs redirected to inclusive of the final destination, exclusive of the original URL.hostcodepath, rather than the IP codepath for execution of the check, previously only used for proxies in heartbeat, for redirects. This simplifies the code, hides timing data that can be screwy with redirects (things like fine grained DNS resolution). This means that the following fields no longer appear with redirects enabled in the event:http.rtt.content.us,http.rtt.response_header.us,http.rtt.total.us,http.rtt.validate.us,http.rtt.write_request.us.max_redirects: 0instead of10The new default does make this a breaking change, however, we either need to break that setting and preserve the timing information for the common use case of someone checking a non-redirecting URL, or keeping it at
10but losing the timing info. The third option would be to invest additional eng. effort here to track those numbers across reqs, but the benefit seems, minimal given that they are not displayed in the UI, only in dashboards.