Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Uptime] Redirects in UI #101

Closed
andrewvc opened this issue Oct 22, 2019 · 7 comments · Fixed by elastic/kibana#65292
Closed

[Uptime] Redirects in UI #101

andrewvc opened this issue Oct 22, 2019 · 7 comments · Fixed by elastic/kibana#65292
Labels
enhancement New feature or request test-plan test-plan-ok Indicates an issue has been tested for release v7.10.0

Comments

@andrewvc
Copy link
Contributor

This is the non-design issue tracking

With elastic/beats#14125 we will now include a list of redirects traversed in checking a URL. There's currently no way to see this info. A check that involves redirects may be interpreted differently than one that does not, so we should indicate this. One key difference is that redirects can be slower than a non-redirects, so one may interpret latency differently.

See #99 for the design of this feature

@andrewvc andrewvc added enhancement New feature or request [zube]: Backlog labels Oct 22, 2019
@katrin-freihofner
Copy link
Contributor

katrin-freihofner commented Dec 2, 2019

Monitor page status

Adding information about redirects: Heartbeat followed N redirects while executing ping.

Screenshot 2019-12-02 at 13 25 23

Individual check details

Adding list of redirected Urls and sort down icon

Screenshot 2019-12-02 at 13 22 09

@shahzad31
Copy link

shahzad31 commented Apr 20, 2020

@katrin-freihofner are we displaying redirects in expanded row in history panel on details page or on monitor list?

From image
image

it looks like it's a expanded row in monitor list also figma link images says the same https://www.figma.com/file/lDlGXMzUTnzAlHPQu7lZAH/Uptime?node-id=130%3A1

but andrew comments and expanded row body in above image seems like it's history panel, since it also has Reponse Body.

Are we going to display in both places?

@katrin-freihofner
Copy link
Contributor

@shahzad31 I think the redirect info belongs to the details page. cc @andrewvc

@andrewvc
Copy link
Contributor Author

Yes, the mock is for the history panel in the details page. Not sure where the confusing comments are, but I'm on the same page as @katrin-freihofner

@shahzad31
Copy link

Confusion was from the image actually, row style is from monitor list
image

Katrin clarified it.

@shahzad31
Copy link

shahzad31 commented Apr 20, 2020

I think for the monitor detail, i liked the original idea better
image

just displaying text doesn't convery much, we should also display popover with redirect list
image

In original issue, i think it was recommended that we update the text but we should keep the popover panel.

WDYT? cc @andrewvc @katrin-freihofner

@katrin-freihofner
Copy link
Contributor

The header gives only a quick overview. The details about redirects are further down in the table. That is why we decided to go that way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request test-plan test-plan-ok Indicates an issue has been tested for release v7.10.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants