Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #12931 to 7.3: Update Go to 1.12.7 #12974

Closed
wants to merge 2 commits into from
Closed

Cherry-pick #12931 to 7.3: Update Go to 1.12.7 #12974

wants to merge 2 commits into from

Conversation

mikemadden42
Copy link
Contributor

Cherry-pick of PR #12931 to 7.3 branch. Original message:

@mikemadden42
Update Go to 1.12.7 (elastic#12931)
6fe8858 
* Update Go to 1.12.7

* Add changelog entry for Go 1.12.7

(cherry picked from commit eae3e45)
@mikemadden42 mikemadden42 requested review from a team as code owners July 18, 2019 20:05
@mikemadden42 mikemadden42 requested a review from andrewkroh July 18, 2019 21:28
andrewkroh
andrewkroh reviewed Jul 19, 2019
View reviewed changes
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update Go for 7.3? The branch has been feature frozen for a few weeks. It's kind of late to make this change, but if it's breaking something we can do it.

@mikemadden42 mikemadden42 requested a review from urso July 23, 2019 15:21
@mikemadden42
Copy link
Contributor Author

jenkins retest this please

@urso
Copy link

urso commented Jul 24, 2019

Not sure if it's too late already, but +1.
The failing tests are unrelated.

@mikemadden42
Copy link
Contributor Author

Go 1.2.8 and 1.2.9 have been released. I'm closing this PR.

@mikemadden42 mikemadden42 deleted the backport_12931_7.3 branch September 19, 2019 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh left review comments

@urso urso urso approved these changes

Assignees
No one assigned
Labels
backport review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikemadden42 @urso @andrewkroh