-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Go to 1.12.7 #12931
Update Go to 1.12.7 #12931
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change should have a CHANGELOG entry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog is added.
@@ -15,6 +15,7 @@ https://github.com/elastic/beats/compare/v7.0.0-alpha2...master[Check the HEAD d | |||
- Update to ECS 1.0.1. {pull}12284[12284] {pull}12317[12317] | |||
- Default of output.kafka.metadata.full is set to false by now. This reduced the amount of metadata to be queried from a kafka cluster. {pull}12738[12738] | |||
- Fixed a crash under Windows when fetching processes information. {pull}12833[12833] | |||
- Update to Golang 1.12.7. {pull}12931[12931] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the future.
The Changelog.next.asciidoc is for users only. If we fix important bugs by upgrading go, then we should add Fix xyz in this file. But the fact that the toolchain has been updated is maybe better put in Changelog-developer.next.asciidoc. WDYT?
* Update Go to 1.12.7 * Add changelog entry for Go 1.12.7 (cherry picked from commit eae3e45)
* Update Go to 1.12.7 * Add changelog entry for Go 1.12.7
No description provided.