Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

span type/subtype: alignment step 1 #513

Merged
merged 5 commits into from
Dec 2, 2021

Conversation

SylvainJuge
Copy link
Member

@SylvainJuge SylvainJuge commented Sep 23, 2021

  • add generic app/internal to replace some internal spans & deprecate those.
  • add to specification that changing span type/subtype is not considered a breaking change.
  • deprecate some fields listed in Alignment of span type/subtype #502 before removal.

@SylvainJuge SylvainJuge requested review from a team as code owners September 23, 2021 12:29
@SylvainJuge SylvainJuge changed the title update spec + add app/internal span type/subtype: update spec + add app/internal Sep 23, 2021
@apmmachine
Copy link

apmmachine commented Sep 23, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-12-02T08:23:47.061+0000

  • Duration: 7 min 49 sec

  • Commit: 01d9b55

@SylvainJuge SylvainJuge changed the title span type/subtype: update spec + add app/internal span type/subtype: alignment step 1 Sep 23, 2021
specs/agents/tracing-spans.md Outdated Show resolved Hide resolved
specs/agents/tracing-spans.md Outdated Show resolved Hide resolved
Co-authored-by: Colton Myers <colton.myers@gmail.com>
@SylvainJuge
Copy link
Member Author

Since this PR does not introduce any breaking change in agents, we can merge it as-is.
A follow-up PR will have to be created afterwards to remove the deprecated fields, this time probably having more impact on agents that do enforce this spec.

@SylvainJuge SylvainJuge enabled auto-merge (squash) December 2, 2021 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants