Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alignment of span type/subtype #502

Open
8 tasks
SylvainJuge opened this issue Sep 8, 2021 · 4 comments
Open
8 tasks

Alignment of span type/subtype #502

SylvainJuge opened this issue Sep 8, 2021 · 4 comments

Comments

@SylvainJuge
Copy link
Member

SylvainJuge commented Sep 8, 2021

This is a meta-issue to describe all the known alignment issues/inconsistencies with span type / subtype

The current state of specification is stored in tests/agents/json-specs/span_types.json in JSON format.

For convenience, we will refer to span type & subtype as type/subtype.
This issue description will be modified when alignment progresses.

List of things that need improvement/simplification/alignment

Process

  1. Agent tests to enforce conformance to shared type/subtype name spec  #555
Agent Add automated span type/subtype checking against shared spec
Java issue details issue details
dot-net issue details issue details
Go issue details issue details
PHP issue details issue details
Ruby issue details issue details
NodeJS issue details issue details
Python issue details issue details
  1. add required type & subtypes the the JSON definition to make tests pass, open PRs (reviews optional)
  2. When merging spec PRs, add known inconsistencies to the list above (if required)
  3. discuss alignment through comments in this issue
  4. goto step 2
@SylvainJuge
Copy link
Member Author

@elastic/apm-agent-ruby there could be a few quick wins here:

  • use external/email instead of app/mailer
  • merge db/sqllite with db/sqlite3

For json/* I think we could use a generic subtype of app (the one we need to find a good name for), using span name should be enough for the end user to know it's about JSON read/write operations.

@mikker
Copy link
Contributor

mikker commented Sep 8, 2021

Completely agree, @SylvainJuge. Good ideas 👍

@SylvainJuge
Copy link
Member Author

Proposal for internal delegation spans, simply call them app/internal (which would somehow align with Otel internal spans).

@SylvainJuge
Copy link
Member Author

Adding app/internal for generic spans: #513 + few other alignment changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants