Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[META 555] Add automated span type/subtype checking against shared spec #2408

Open
4 tasks
SylvainJuge opened this issue Nov 2, 2021 · 0 comments
Open
4 tasks

[META 555] Add automated span type/subtype checking against shared spec #2408

SylvainJuge opened this issue Nov 2, 2021 · 0 comments
Labels
8.3-candidate agent-nodejs Make available for APM Agents project planning.

Comments

@SylvainJuge
Copy link
Member

Add checking the shared JSON spec for span types & sub-types.

Relates to elastic/apm#502

Implementation checklist

  • add/modify existing tests to ensure that the spec is being enforced for tests (unit or integration), the goal is to make it transparent to any contributor.
  • add to/modify existing spec to allow agent tests to pass if there is any failure
  • merge the PR that will implement this
  • add any inconsistency to Alignment of span type/subtype apm#502 description
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Nov 2, 2021
@SylvainJuge SylvainJuge mentioned this issue Nov 2, 2021
Open
8 tasks
@AlexanderWert AlexanderWert changed the title Add automated span type/subtype checking against shared spec [META 555] Add automated span type/subtype checking against shared spec Nov 18, 2021
@AlexanderWert AlexanderWert mentioned this issue Nov 18, 2021
Open
7 tasks
@estolfo estolfo added this to the 8.1 milestone Jan 24, 2022
@estolfo estolfo removed this from the 8.1 milestone Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
8.3-candidate agent-nodejs Make available for APM Agents project planning.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@estolfo @SylvainJuge @AlexanderWert