Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix test failure due to os.freemem() behaviour change in node v17.4.0 #2540

Merged
merged 2 commits into from
Jan 20, 2022

Conversation

trentm
Copy link
Member

@trentm trentm commented Jan 20, 2022

The update to libuv 1.43.0 changed the behaviour of os.freemem() on
Linux to report "MemAvailable" from /proc/meminfo rather than "MemFree".

Refs: #2530

(Most test runs for all PRs will fail when testing against node v17 until this is merged in.)

…v17.4.0

The update to libuv 1.43.0 changed the behaviour of os.freemem() on
Linux to report "MemAvailable" from /proc/meminfo rather than "MemFree".

Refs: #2530
@trentm trentm requested a review from astorm January 20, 2022 00:40
@trentm trentm self-assigned this Jan 20, 2022
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Jan 20, 2022
@apmmachine
Copy link
Contributor

apmmachine commented Jan 20, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-01-20T10:07:01.340+0000

  • Duration: 23 min 16 sec

  • Commit: 1868d7e

Test stats 🧪

Test Results
Failed 0
Passed 243027
Skipped 0
Total 243027

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run module tests for <modules> : Run TAV tests for one or more modules, where <modules> can be either a comma separated list of modules (e.g. memcached,redis) or the string literal ALL to test all modules

  • run benchmark tests : Run the benchmark test only.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@trentm trentm merged commit 2187c63 into main Jan 20, 2022
@trentm trentm deleted the trentm/fix-node17.4.0-test-failure branch January 20, 2022 16:26
@trentm trentm mentioned this pull request Jan 20, 2022
4 tasks
astorm pushed a commit that referenced this pull request Feb 4, 2022
…v17.4.0 (#2540)

The update to libuv 1.43.0 changed the behaviour of os.freemem() on
Linux to report "MemAvailable" from /proc/meminfo rather than "MemFree".

Refs: #2530
trentm added a commit that referenced this pull request Feb 10, 2022
…v16.14.0

The update to libuv 1.43.0 changed the behaviour of os.freemem() on
Linux to report "MemAvailable" from /proc/meminfo rather than "MemFree".

Refs: #2530, #2540
trentm added a commit that referenced this pull request Feb 10, 2022
…v16.14.0 (#2570)

The update to libuv 1.43.0 changed the behaviour of os.freemem() on
Linux to report "MemAvailable" from /proc/meminfo rather than "MemFree".

Refs: #2530, #2540
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-nodejs Make available for APM Agents project planning.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants