-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: fix test failure due to os.freemem() behaviour change in node v18 #2530
Conversation
Recent node v18 nightly builds changed the behaviour of os.freemem() on Linux to report "MemAvailable" from /proc/meminfo rather than "MemFree". This broke our tests.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
…v17.4.0 The update to libuv 1.43.0 changed the behaviour of os.freemem() on Linux to report "MemAvailable" from /proc/meminfo rather than "MemFree". Refs: #2530
…v18 (#2530) Recent node v18 nightly builds changed the behaviour of os.freemem() on Linux to report "MemAvailable" from /proc/meminfo rather than "MemFree". This broke our tests.
Recent node v18 nightly builds changed the behaviour of os.freemem()
on Linux to report "MemAvailable" from /proc/meminfo rather than
"MemFree". This broke our tests.
The nightly "edge" tests started failing ~6-7 days ago with:
The breakage started in node nightly build "v18.0.0-nightly20220107b6b6510187".
The culprit node change was nodejs/node#41398, which upgrades libuv, which brought in a change to
os.freemem()
on Linux: libuv/libuv#3351This broke an assumption in our tests.