Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): remove Node.js 5 and 7 from test matrix #169

Merged
merged 1 commit into from
Jan 11, 2018

Conversation

Qard
Copy link
Contributor

@Qard Qard commented Jan 9, 2018

Fixes #158

Copy link
Contributor

@watson watson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll also need to update the compatibly section of our docs and the engine field:

"engines": {
"node": ">=4.0.0"
},

@Qard
Copy link
Contributor Author

Qard commented Jan 10, 2018

updated.

@watson watson merged commit 343edb5 into elastic:elastic-6.2 Jan 11, 2018
watson pushed a commit that referenced this pull request Jan 11, 2018
Fixes #158

BREAKING CHANGE: Support for Node.js version 5+7 are now dropped
@Qard Qard deleted the drop-5-and-7 branch January 11, 2018 21:26
watson pushed a commit that referenced this pull request Jan 13, 2018
Fixes #158

BREAKING CHANGE: Support for Node.js version 5+7 are now dropped
watson pushed a commit that referenced this pull request Jan 13, 2018
Fixes #158

BREAKING CHANGE: Support for Node.js version 5+7 are now dropped
watson pushed a commit that referenced this pull request Jan 14, 2018
Fixes #158

BREAKING CHANGE: Support for Node.js version 5+7 are now dropped
watson pushed a commit that referenced this pull request Jan 15, 2018
Fixes #158

BREAKING CHANGE: Support for Node.js version 5+7 are now dropped
watson pushed a commit to watson/apm-agent-nodejs that referenced this pull request Jan 17, 2018
Fixes elastic#158

BREAKING CHANGE: Support for Node.js version 5+7 are now dropped
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants