Skip to content

Commit

Permalink
chore(*): drop support for Node.js 5 and 7 (#169)
Browse files Browse the repository at this point in the history
Fixes #158

BREAKING CHANGE: Support for Node.js version 5+7 are now dropped
  • Loading branch information
Qard authored and watson committed Jan 13, 2018
1 parent 57eca45 commit 43db0ca
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 47 deletions.
38 changes: 0 additions & 38 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,7 @@ before_script:
node_js:
- '9'
- '8'
- '7.9.0' # currently 7.10.0 fails. For details see: https://github.com/nodejs/node/pull/12861
- '6'
- '5'
- '4'

jobs:
Expand Down Expand Up @@ -99,24 +97,6 @@ jobs:
env: TAV=knex,ws,graphql,express-graphql,elasticsearch,hapi,express
script: 'if ! [[ $TRAVIS_BRANCH == greenkeeper/* ]]; then tav --quiet; fi'

# Node.js 7.9
-
node_js: '7.9'
env: TAV=generic-pool,mysql,redis,koa-router,handlebars,mongodb-core
script: 'if ! [[ $TRAVIS_BRANCH == greenkeeper/* ]]; then tav --quiet; fi'
-
node_js: '7.9'
env: TAV=ioredis,pg
script: 'if ! [[ $TRAVIS_BRANCH == greenkeeper/* ]]; then tav --quiet; fi'
-
node_js: '7.9'
env: TAV=bluebird
script: 'if ! [[ $TRAVIS_BRANCH == greenkeeper/* ]]; then tav --quiet; fi'
-
node_js: '7.9'
env: TAV=knex,ws,graphql,express-graphql,elasticsearch,hapi,express
script: 'if ! [[ $TRAVIS_BRANCH == greenkeeper/* ]]; then tav --quiet; fi'

# Node.js 6
-
node_js: '6'
Expand All @@ -135,24 +115,6 @@ jobs:
env: TAV=knex,ws,graphql,express-graphql,elasticsearch,hapi,express
script: 'if ! [[ $TRAVIS_BRANCH == greenkeeper/* ]]; then tav --quiet; fi'

# Node.js 5
-
node_js: '5'
env: TAV=generic-pool,mysql,redis,koa-router,handlebars,mongodb-core
script: 'if ! [[ $TRAVIS_BRANCH == greenkeeper/* ]]; then tav --quiet; fi'
-
node_js: '5'
env: TAV=ioredis,pg
script: 'if ! [[ $TRAVIS_BRANCH == greenkeeper/* ]]; then tav --quiet; fi'
-
node_js: '5'
env: TAV=bluebird
script: 'if ! [[ $TRAVIS_BRANCH == greenkeeper/* ]]; then tav --quiet; fi'
-
node_js: '5'
env: TAV=knex,ws,graphql,express-graphql,elasticsearch,hapi,express
script: 'if ! [[ $TRAVIS_BRANCH == greenkeeper/* ]]; then tav --quiet; fi'

# Node.js 4
-
node_js: '4'
Expand Down
9 changes: 5 additions & 4 deletions docs/compatibility.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -7,17 +7,18 @@ endif::[]

== Compatibility Overview

The Elastic APM Node.js agent is tested against Node.js v4.0.0 and above.
Previous versions of Node.js are not supported.
Support for the Elastic APM Node.js agent follows the support schedule of Node.js itself to the end-of-line period of each version after its maintenance term.
Versions of Node.js past their end-of-life date are not supported.

image::https://raw.githubusercontent.com/nodejs/Release/master/schedule.png[]

Some versions of Node.js contain bugs or issues that limit our ability to instrument them correctly.
The following versions of Node.js are known to not be fully instrumented:

- v7.10.x - Recommended solution: Upgrade to v8.2.0 or higher to get full support
- v8.0.x - Recommended solution: Upgrade to v8.2.0 or higher to get full support
- v8.1.x - Recommended solution: Upgrade to v8.2.0 or higher to get full support

NOTE: Support for Node.js 8.2.0 and above is experimental as it makes use the experimental core API https://nodejs.org/api/async_hooks.html[Async Hooks].
NOTE: Support for Node.js 8.2.0 and above is experimental as it makes use of the experimental core API https://nodejs.org/api/async_hooks.html[Async Hooks].
If you experience any issues related to using Async Hooks,
you can always disable the use of this API by setting the <<async-hooks,`asyncHooks`>> config option to `false`.
Note however,
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"url": "git://github.com/elastic/apm-agent-nodejs.git"
},
"engines": {
"node": ">=4.0.0"
"node": "4 || 6 || >= 8"
},
"keywords": [
"opbeat",
Expand Down
2 changes: 0 additions & 2 deletions test/.jenkins_nodejs.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
NODEJS_VERSION:
- "9"
- "8"
- "7.9.0"
- "6"
- "5"
- "4"
2 changes: 0 additions & 2 deletions test/.jenkins_tav_nodejs.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
NODEJS_VERSION:
- "9"
- "8"
- "7.9"
- "6"
- "5"
- "4"

0 comments on commit 43db0ca

Please sign in to comment.