-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add dynamic badge #813
Conversation
| `ELASTIC_APM_SERVICE_NAME` | `ElasticApm:ServiceName` | ||
|============ | ||
|
||
[options="header"] | ||
|============ | ||
| Default | Type | ||
| Name of the entry assembly | String |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about all of these. Just updated my formatting rules. I can remove them from this PR if you'd like.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries, all valid changes - feel free to keep those.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very nice! 👏
To the questions:
CaptureBodyContentTypes
Will we still offer a text field in Kibana to put in any config name for central config? If yes, I think we can mark it as dynamic, otherwise I’d just not mark it as dynamic and we can follow up later on this.
What do you think of this approach for documenting this feature?
I like it a lot. It’s way easier to spot which ones are dynamic 👍
Codecov Report
@@ Coverage Diff @@
## master #813 +/- ##
==========================================
+ Coverage 80.44% 81.36% +0.91%
==========================================
Files 114 114
Lines 5379 5542 +163
==========================================
+ Hits 4327 4509 +182
+ Misses 1052 1033 -19
Continue to review full report at Codecov.
|
Awesome! If it's alright, I'll wait until tomorrow to merge this. I'm using this PR and a similar one in the Python repository for feedback on this documentation approach before applying it to all Agents.
No, only the seven configurations listed in the description will be configurable. Sounds good. I'll leave it unmarked for now. |
I should have not talked about the CI on this PR... The last build reached time-out (1 hour - it was already almost done) 😱 - I have never seen that (currently it takes around 55mins usually - 25 from that is just installing tools). Re-triggered. |
What does this pull request do?
Dynamic
badge to supported configurations:capture_body
TransactionSampleRate
TransactionMaxSpans
Dynamic
badge to pending (New central config options: CaptureHeaders, LogLevel, SpanFramesMinDuration, StackTraceLimit #794) configurations:capture_headers
log_level
span_frames_min_duration
stack_trace_limit
Dynamic configuration
.Open questions:
CaptureBodyContentTypes
shows as reloadable, but it isn't supported in the APM app. See: https://github.com/elastic/kibana/blob/master/x-pack/plugins/apm/common/agent_configuration/setting_definitions/general_settings.ts. How should we mark this config?Documentation preview
http://apm-agent-dotnet_813.docs-preview.app.elstc.co/diff
Related issues
For elastic/apm#232
For https://github.com/elastic/observability-dev/issues/639