Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Document new Central configuration support #232

Closed
bmorelli25 opened this issue Mar 30, 2020 · 4 comments · Fixed by elastic/kibana#63280
Closed

[docs] Document new Central configuration support #232

bmorelli25 opened this issue Mar 30, 2020 · 4 comments · Fixed by elastic/kibana#63280
Assignees

Comments

@bmorelli25
Copy link
Member

bmorelli25 commented Mar 30, 2020

Summary

Central configuration will be enabled for all dynamic parameters in 7.7. These new parameters need to be documented somewhere.

Currently

Currently, we document supported parameters in the Kibana reference. This makes sense, as prior to this update, all Agents supported the same few configurations. With more configurations coming online, this might not make sense for 7.7.

Solution

We should make a note of supported configuration options in each Agent reference. There are a few ways we could do this...

Custom badge

A custom badge would be very easy to scan for. This could help supported parameters stand out, and would link to more information on the feature. As a quick example, I created this badge and added it to the first two configurations in the Python reference:

Screen Shot 2020-03-30 at 11 06 58 AM

or...

Screen Shot 2020-03-30 at 9 33 25 AM

Unfortunately, these badges have to be inline, and we're very limited in terms of how asciidoctor displays something like this.

Just another paragraph

Doesn't pop as much, but maybe it doesn't need to.

Screen Shot 2020-03-30 at 11 07 25 AM

Related issues

Related PRs

@bmorelli25
Copy link
Member Author

bmorelli25 commented Mar 30, 2020

The Java Agent documents dynamic parameters: https://www.elastic.co/guide/en/apm/agent/java/master/configuration.html#configuration-dynamic. Perhaps this is a better route to go?

cc @felixbarny since you seem to be leading the Central configuration charge

@felixbarny
Copy link
Member

The downside of tagging options explicitly with Central configuration ✔️ is that there might be other configuration sources, like configuration files, that allow options to be reloaded. That's why we mark them with Dynamic true:

Screen Shot 2020-03-31 at 08 43 35

However, Dynamic=true does not really pop out as nice as the badge does and "dynamic" sounds a bit vague. Maybe we could have a badge for Reloadable option ✔️ that also acts as a link to the section explaining what dynamic/reloadable options are and which configuration sources support reloading:

Screen Shot 2020-03-31 at 08 50 54

@bmorelli25
Copy link
Member Author

I'm shying away from "reloadable" as it's not a real word. Elasticsearch also uses dynamic, which I think is descriptive enough.

@bmorelli25
Copy link
Member Author

All agents have PRs opened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants