-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lambda reconstruction in ZDC #1731
Open
sebouh137
wants to merge
20
commits into
main
Choose a base branch
from
lambda_zdc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+566
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
separate collection for single-neutron recon in ZDC
added single-neutron reconstruction back in (under "stand alone").
According to massif, histograms from pid_lut take 15% of memory, which is disproportional to the functionality provided. We can gain some memory back by adjusting the precision. ### Briefly, what does this PR introduce? ### What kind of change does this PR introduce? - [ ] Bug fix (issue #__) - [ ] New feature (issue #__) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [ ] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? No ### Does this PR change default behavior? No
Electron threshold was used for sampling protons due to what looks like some copy-paste error. The threshold reported in ParticleID for 2212 is correct, however. Basically, this is only issue for `ReconstructedParticles.PDG`. ### Briefly, what does this PR introduce? ### What kind of change does this PR introduce? - [x] Bug fix (issue #__) - [ ] New feature (issue #__) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [ ] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? No ### Does this PR change default behavior? Yes
for more information, see https://pre-commit.ci
separate collection for single-neutron recon in ZDC
added single-neutron reconstruction back in (under "stand alone").
for more information, see https://pre-commit.ci
Capybara summary for PR 1731
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
topic: calorimetry
relates to calorimetry
topic: far-forward
Far forward reconstruction
topic: infrastructure
topic: PID
Relates to PID reconstruction
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
Reconstruction of Lambda baryons using the ZDC. Also includes functionality to reconstruction photons and neutrons in the ZDC and distinguish between them.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
no
Does this PR change default behavior?
Yes. Adds two new algorithms (one for photon and neutron recon in the ZDC, and a second to find/fit lambda candidates from these particles).