Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: PIDLookup: fix proton sampling threshold #1728

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Feb 5, 2025

Electron threshold was used for sampling protons due to what looks like some copy-paste error. The threshold reported in ParticleID for 2212 is correct, however. Basically, this is only issue for ReconstructedParticles.PDG.

Briefly, what does this PR introduce?

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No

Does this PR change default behavior?

Yes

Electron threshold was used due to what looks like some copy-paste error.
@veprbl veprbl requested review from a team, simonge and wdconinc and removed request for a team February 5, 2025 17:56
@veprbl veprbl added this pull request to the merge queue Feb 7, 2025
Merged via the queue into main with commit 9a54a66 Feb 7, 2025
52 of 57 checks passed
@veprbl veprbl deleted the pr/pid_lut_bugfix branch February 7, 2025 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants