Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX/HCMPRE-15830 : Fixed checkbox click area #2064

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

abishekTa-egov
Copy link
Contributor

@abishekTa-egov abishekTa-egov commented Dec 19, 2024

Bugfix/hcmpre 15830: CSS fix for checkbox in usermanagement

Summary by CodeRabbit

  • New Features

    • Updated CSS stylesheet version for improved styling and functionality across health-related components.
  • Bug Fixes

    • Enhanced styles for various UI components, including improved alignment, responsiveness, and hover effects.

@abishekTa-egov abishekTa-egov requested a review from a team as a code owner December 19, 2024 06:15
Copy link
Contributor

coderabbitai bot commented Dec 19, 2024

📝 Walkthrough

Walkthrough

This pull request involves updating the CSS stylesheet version for the health module across multiple HTML files. Specifically, the changes update the @egovernments/digit-ui-health-css stylesheet from version 0.2.3 to 0.2.31 in two HTML files: one in the micro-ui internals example directory and another in the public web directory. Additionally, the SCSS file microplan.scss was modified with various styling improvements for UI components.

Changes

File Change Summary
health/micro-ui/web/micro-ui-internals/example/public/index.html Updated CSS stylesheet version from 0.2.3 to 0.2.31
health/micro-ui/web/public/index.html Updated CSS stylesheet version from 0.2.3 to 0.2.31
health/micro-ui/web/micro-ui-internals/packages/css/src/components/microplan.scss Comprehensive styling updates for various UI components, including new styles for .inbox-search-wrapper, .pagination-controls, .activity-grid, and other UI elements

Possibly related PRs

Suggested reviewers

  • nipunarora-eGov

Poem

🐰 A Stylesheet's Journey

From version point-two-three to thirty-one,
Our CSS dances, its styling begun!
Pixels align with a magical flair,
Micro-UI's beauty beyond compare!
Hop, hop, hurray for the code so bright! 🌈


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4cb3199 and 2d7d51e.

⛔ Files ignored due to path filters (1)
  • health/micro-ui/web/micro-ui-internals/packages/css/package.json is excluded by !**/*.json
📒 Files selected for processing (3)
  • health/micro-ui/web/micro-ui-internals/example/public/index.html (1 hunks)
  • health/micro-ui/web/micro-ui-internals/packages/css/src/components/microplan.scss (1 hunks)
  • health/micro-ui/web/public/index.html (1 hunks)
🧰 Additional context used
📓 Learnings (1)
health/micro-ui/web/micro-ui-internals/packages/css/src/components/microplan.scss (1)
Learnt from: siddhant-nawale-egov
PR: egovernments/DIGIT-Frontend#876
File: micro-ui/web/micro-ui-internals/packages/css/src/components/microplanning.scss:1940-2392
Timestamp: 2024-11-10T20:01:49.000Z
Learning: Classes related to interactive elements in the microplan preview section are mostly passed to Higher Order Components (HOCs), and ARIA attributes for non-HOC elements will be managed directly by adding them where necessary.
🔇 Additional comments (3)
health/micro-ui/web/micro-ui-internals/packages/css/src/components/microplan.scss (1)

263-266: LGTM! Checkbox positioning fix looks good.

The CSS changes properly target checkboxes within the inbox search component with specific positioning adjustments. This should resolve the alignment issues.

Let's verify if this selector targets all necessary checkbox instances:

✅ Verification successful

Checkbox positioning changes are correctly scoped

The search results confirm that the checkbox positioning changes in microplan.scss are specific to the inbox search component and don't conflict with other checkbox styles in the codebase. Other checkbox-related styles either:

  • Have different positioning contexts (like in surveys.scss and workbench.scss)
  • Use different selectors and properties (like margin-left in checkbox.scss and checkboxV2.scss)
  • Are part of different components (like dropdowns and toggles)
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for other checkbox-related styles that might need similar adjustments
rg -l "checkbox" | xargs rg "top:|left:" 

Length of output: 15042

health/micro-ui/web/micro-ui-internals/example/public/index.html (1)

15-15: LGTM! CSS version update is consistent.

The health CSS package version has been updated to include the new checkbox positioning fixes.

health/micro-ui/web/public/index.html (1)

13-13: LGTM! CSS version update maintains consistency.

The health CSS package version has been updated to match the version in the example directory, ensuring consistent checkbox styling across the application.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@abishekTa-egov abishekTa-egov changed the title Bugfix/hcmpre 15830: CSS fix for checkbox in usermanagement BUGFIX/HCMPRE-15830 Dec 19, 2024
@nipunarora-eGov nipunarora-eGov changed the title BUGFIX/HCMPRE-15830 BUGFIX/HCMPRE-15830 : Fixed checkbox click area Dec 19, 2024
@nipunarora-eGov nipunarora-eGov merged commit 0ed7ed8 into console Dec 19, 2024
4 checks passed
@nipunarora-eGov nipunarora-eGov deleted the BUGFIX/HCMPRE-15830 branch December 19, 2024 06:35
nipunarora-eGov pushed a commit that referenced this pull request Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants