FEATURE/HCMPRE-1634:Fixed all the version updates #2026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📝 WalkthroughWalkthroughThis pull request includes updates to two HTML files, specifically Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Outside diff range comments (2)
health/micro-ui/web/micro-ui-internals/example/public/index.html (1)
Line range hint
18-19: Clean up commented code.Remove commented-out CSS imports to improve code maintainability:
- <!-- <link rel="stylesheet" href="https://unpkg.com/@egovernments/digit-ui-css@1.5.41/dist/index.css" /> -->health/micro-ui/web/public/index.html (1)
Line range hint
1-35: Align page titles across environments.The page titles differ between the two index.html files:
- This file: "DIGIT HCM"
- Other file: "DIGIT"
Consider standardizing the titles or documenting the reason for the difference.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (9)
health/micro-ui/web/core/package.jsonis excluded by!**/*.jsonhealth/micro-ui/web/micro-ui-internals/example/package.jsonis excluded by!**/*.jsonhealth/micro-ui/web/micro-ui-internals/package.jsonis excluded by!**/*.jsonhealth/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/package.jsonis excluded by!**/*.jsonhealth/micro-ui/web/micro-ui-internals/packages/modules/microplan/package.jsonis excluded by!**/*.jsonhealth/micro-ui/web/micro-ui-internals/packages/modules/workbench-hcm/package.jsonis excluded by!**/*.jsonhealth/micro-ui/web/microplan/package.jsonis excluded by!**/*.jsonhealth/micro-ui/web/package.jsonis excluded by!**/*.jsonhealth/micro-ui/web/workbench/package.jsonis excluded by!**/*.json
📒 Files selected for processing (2)
health/micro-ui/web/micro-ui-internals/example/public/index.html(1 hunks)health/micro-ui/web/public/index.html(1 hunks)
🔇 Additional comments (2)
health/micro-ui/web/public/index.html (2)
Line range hint 16-16: Review script dependency consistency.
The xlsx script is only included in this file but not in the other index.html. Verify if this dependency is required in both files.
Let's check for xlsx usage:
Also applies to: 17-17
11-11: Verify beta version upgrade compatibility.
The upgrade from beta.42 to beta.43 of digit-ui-components-css should be verified for breaking changes.
Let's check for any documented changes:
nipunarora-eGov
approved these changes
Dec 13, 2024
nipunarora-eGov
changed the title
nipunarora-eGov
pushed a commit
that referenced
this pull request
Dec 16, 2024
FEATURE/HCMPRE-1634: Fixed all the version updates
This was referenced Dec 16, 2024
jagankumar-egov
added a commit
that referenced
this pull request
Dec 16, 2024
* Update UserManagement.js (#2017) Co-authored-by: Nipun Arora <aroranipun1@gmail.com> * updated core version (#2020) * Bugfix/hcmpre 1583 (#2021) * Update MicroplanSearch.js * Pagination issues --------- Co-authored-by: Nipun Arora <aroranipun1@gmail.com> * BUGFIX/HCMPRE-1634: fix for versions (#2024) * Revert "Bugfix/hcmpre 1583 (#2021)" This reverts commit 201a0ce. * BUGFIX/HCMPRE-1634 Revert ing"updated core version (#2020)" * BUGFIX/HCMPRE-1583 fixes --------- Co-authored-by: Swathi-eGov <swathi.chatrathi@egovernments.org> * FEATURE/HCMPRE-1634:Fixed all the version updates (#2026) FEATURE/HCMPRE-1634: Fixed all the version updates * Update package.json --------- Co-authored-by: Swathi-eGov <137176788+Swathi-eGov@users.noreply.github.com> Co-authored-by: Nipun Arora <aroranipun1@gmail.com> Co-authored-by: abishekTa-egov <abishek.t@egovernments.org> Co-authored-by: Swathi-eGov <swathi.chatrathi@egovernments.org>
This was referenced Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Choose the appropriate template for your PR:
Feature PR
Feature Request
JIRA ID
Module
Description
Related Issues
Bugfix PR
Bugfix Request
JIRA ID
Module
Description
Root Cause
Related Issues
Release PR
Summary by CodeRabbit
New Features
@egovernments/digit-ui-components-cssfor improved styling.Bug Fixes