add some test cases (work on tmp_folder) #1
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Playing with the tests that you proposed for conan-io#4092 I found one use case that is failing, check this line: https://github.com/efremovd/conan/compare/ftp-download-auth...jgsogo:efremovd-ftp-download-auth?expand=1#diff-3c7937871325b48b30cc01374d2a0cbaR37. Please, consider this PR and let me know if your are going to fix the
invalid-file
issue or if you want me to propose the change.Also, I've rewritten the test class to use a temp folder and clean it up when everything is finished.
Thanks!! All contributions are more than welcome 👐