Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some test cases (work on tmp_folder) #1

Merged

Conversation

jgsogo
Copy link

@jgsogo jgsogo commented Dec 11, 2018

Hi! Playing with the tests that you proposed for conan-io#4092 I found one use case that is failing, check this line: https://github.com/efremovd/conan/compare/ftp-download-auth...jgsogo:efremovd-ftp-download-auth?expand=1#diff-3c7937871325b48b30cc01374d2a0cbaR37. Please, consider this PR and let me know if your are going to fix the invalid-file issue or if you want me to propose the change.

Also, I've rewritten the test class to use a temp folder and clean it up when everything is finished.

Thanks!! All contributions are more than welcome 👐

@efremovd
Copy link
Owner

Hi, thanks :). So what you are saying is that it still creates empty file even though it does not exist on ftp.

I'll fix it later, thank you anyway.

@efremovd efremovd merged commit 151881a into efremovd:ftp-download-auth Dec 11, 2018
@jgsogo jgsogo deleted the efremovd-ftp-download-auth branch December 12, 2018 08:56
@jgsogo
Copy link
Author

jgsogo commented Dec 12, 2018

So what you are saying is that it still creates empty file even though it does not exist on ftp.

Yes, that is a bug in Conan sources, not related to your issue/fix, but I think it can go in the same PR.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants