Fixes ftp download when authentication is required #4092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jgsogo
previously approved these changes
Dec 10, 2018
lasote
approved these changes
Dec 10, 2018
There was a problem hiding this comment.
You are right:
class ftplib.FTP([host[, user[, passwd[, acct[, timeout]]]]])
Return a new instance of the FTP class. When host is given, the method call connect(host) is made.
When user is given, additionally the method call login(user, passwd, acct) is made ....
|
Hi, Thanks for pointing out. I've update tests and code to support anonymous ftp too. |
jgsogo
dismissed
their stale review
At least there is an use-case that is wrong (see my PR to efremovd branch)
add some test cases (work on tmp_folder)
jgsogo
approved these changes
Dec 12, 2018
memsharded
approved these changes
Dec 12, 2018
grisumbras
pushed a commit
to grisumbras/conan
that referenced
this pull request
Dec 27, 2018
* Fixes ftp download when authentication is required * Fixes back anonymous ftp download * add some test cases (work on tmp_folder) * Fixes ftp download of file that does not exist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Bugfix: In ftp_download function there is extra call to ftp.login() with empty args. This causes ftp lib to login again with empty credentials and throwing exception because authentication is required by server.
Docs: omit
It's a small fix so I did not create any issue about it.