-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
helm: Restore the ability to start a cluster in conformance mode by disabling the cilium ipmasq agent when in conformance mode #3062
Conversation
✅ Deploy Preview for constellation-docs canceled.
|
I currently get the following error when trying to set up a cluster on GCP: |
It looks like you're not only disabling the ip-masq-agent, but also the entire eBPF service resolution mechanism (kubeProxyReplacement) - could you please document why this is necessary? |
What kind of documentation do you want? Do you want a user-facing documentation of the |
Hm, I don't get any error when initializing a Constellation on gcp. |
This kind of documentation, as.a comment right here where we set it. Future readers may be interested in the reason for the different configuration in conformance mode, or whether/when it's ok to change it back. I still don't understand why we need to go from partial replacement to no replacement, unless the previous configuration (minus ip-masq-agent) never worked to begin with. |
Using
Will do hopefully later today. |
I deployed this branch on GCP without problems. |
However, the conformance test did not pass: - name: '[It] [sig-network] Services should serve endpoints on same port and different
protocols [Conformance]'
status: failed |
Got a successful run with K8s 1.28 on Azure. |
e6d3905
to
4597d68
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks for the detailed warning!
4597d68
to
9f52d3c
Compare
Coverage report
|
Context
Proposed change(s)
I tested this on AWS.
Checklist