Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

分库分表: 排序merger的nullable数据的支持 #195

Merged
merged 7 commits into from
May 8, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
- [eorm: 修复单条查询时连接泄露问题](https://github.com/ecodeclub/eorm/pull/188)
- [eorm: 分库分表: 结果集处理--聚合函数(含GroupBy子句)](https://github.com/ecodeclub/eorm/pull/193)
- [eorm: 分库分表: NOT 支持](https://github.com/ecodeclub/eorm/pull/191)
- [eorm: 分库分表: Merger NullAble类型数据的支持(sortMerger)](https://github.com/ecodeclub/eorm/pull/195)

## v0.0.1:
- [Init Project](https://github.com/ecodeclub/eorm/pull/1)
Expand Down
1 change: 1 addition & 0 deletions internal/merger/internal/errs/error.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ var (
ErrMergerAggregateHasEmptyRows = errors.New("merger: 聚合函数计算时rowsList有一个或多个为空")
ErrMergerInvalidAggregateColumnIndex = errors.New("merger: ColumnInfo的index不合法")
ErrMergerAggregateFuncNotFound = errors.New("merger: 聚合函数方法未找到")
ErrMergerNullable = errors.New("merger: 接收数据的类型需要为sql.Nullable")
)

func NewRepeatSortColumn(column string) error {
Expand Down
44 changes: 39 additions & 5 deletions internal/merger/sortmerger/heap.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,11 @@

package sortmerger

import "reflect"
import (
"database/sql/driver"
"reflect"
"time"
)

var compareFuncMapping = map[reflect.Kind]func(any, any, Order) int{
reflect.Int: compare[int],
Expand Down Expand Up @@ -45,8 +49,14 @@ func (h *Heap) Less(i, j int) bool {
for k := 0; k < h.sortColumns.Len(); k++ {
valueI := h.h[i].sortCols[k]
valueJ := h.h[j].sortCols[k]
kind := reflect.TypeOf(valueI).Kind()
cp := compareFuncMapping[kind]
_, ok := valueJ.(driver.Valuer)
var cp func(any, any, Order) int
juniaoshaonian marked this conversation as resolved.
Show resolved Hide resolved
if ok {
cp = compareNullable
} else {
kind := reflect.TypeOf(valueI).Kind()
cp = compareFuncMapping[kind]
}
res := cp(valueI, valueJ, h.sortColumns.Get(k).order)
if res == 0 {
continue
Expand Down Expand Up @@ -84,11 +94,35 @@ type node struct {

func compare[T Ordered](ii any, jj any, order Order) int {
i, j := ii.(T), jj.(T)
if i < j && order || i > j && !order {
if i < j && order == ASC || i > j && order == DESC {
return -1
} else if i > j && order || i < j && !order {
} else if i > j && order == ASC || i < j && order == DESC {
return 1
} else {
return 0
}
}

func compareNullable(ii, jj any, order Order) int {
i := ii.(driver.Valuer)
j := jj.(driver.Valuer)
iVal, _ := i.Value()
jVal, _ := j.Value()
// 如果i,j都为空返回0
// 如果val返回为空永远是最小值
if iVal == nil && jVal == nil {
return 0
} else if iVal == nil && order == ASC || jVal == nil && order == DESC {
return -1
} else if iVal == nil && order == DESC || jVal == nil && order == ASC {
return 1
}

vali, ok := iVal.(time.Time)
if ok {
valj := jVal.(time.Time)
return compare[int64](vali.UnixMilli(), valj.UnixMilli(), order)
}
kind := reflect.TypeOf(iVal).Kind()
return compareFuncMapping[kind](iVal, jVal, order)
}
Loading