Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

分库分表: 排序merger的nullable数据的支持 #195

Merged
merged 7 commits into from
May 8, 2023

Conversation

juniaoshaonian
Copy link
Collaborator

在sortmerger中支持nullable类型,大佬们看看这样搞可以不

@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Merging #195 (408c4e1) into dev (400c80e) will increase coverage by 0.05%.
The diff coverage is 87.75%.

@@            Coverage Diff             @@
##              dev     #195      +/-   ##
==========================================
+ Coverage   85.85%   85.91%   +0.05%     
==========================================
  Files          44       45       +1     
  Lines        3274     3309      +35     
==========================================
+ Hits         2811     2843      +32     
- Misses        372      374       +2     
- Partials       91       92       +1     
Impacted Files Coverage Δ
internal/merger/sortmerger/merger.go 89.85% <66.66%> (-0.05%) ⬇️
internal/merger/utils/convert_assign.go 66.66% <66.66%> (ø)
internal/merger/sortmerger/heap.go 98.33% <100.00%> (+1.36%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

internal/merger/internal/errs/error.go Outdated Show resolved Hide resolved
internal/merger/sortmerger/heap.go Outdated Show resolved Hide resolved
internal/merger/sortmerger/merger_test.go Outdated Show resolved Hide resolved
internal/merger/utils/convert_Assign.go Outdated Show resolved Hide resolved
internal/merger/sortmerger/heap.go Show resolved Hide resolved
internal/merger/sortmerger/heap.go Outdated Show resolved Hide resolved
internal/merger/utils/convert_Assign.go Outdated Show resolved Hide resolved
internal/merger/sortmerger/merger_test.go Outdated Show resolved Hide resolved
internal/merger/sortmerger/merger_test.go Outdated Show resolved Hide resolved
internal/merger/utils/convert_Assign.go Show resolved Hide resolved
internal/merger/utils/convert_Assign_test.go Outdated Show resolved Hide resolved
@flycash
Copy link
Contributor

flycash commented May 3, 2023

我已经验证过了,如果用户直接使用基本类型去接收 NULL,会出现 error。但是如果用户用基本类型的指针去接收 NULL,那么能够正常处理。

@longyue0521 的说法应该算是正确的,也就是我们倾向于认为用户应该使用 sql.NullXXX 类型或者自己实现类似的类型去处理 NULL 列。可惜的是 sql.NullXXX 出现得比较晚,所以目前 GO 这边的传统是用指针。

这也是很无奈的事情。

最后一点,将这个 err error 放进去 if ok 内部。然后再将文件名改名为 convert_assign.go 和 convert_assign_test.go

@flycash
Copy link
Contributor

flycash commented May 3, 2023

#198

@flycash
Copy link
Contributor

flycash commented May 3, 2023

把 deepsource 修一下,把 convertAssign 改名叫做 sqlConvertAssign。这个 deepsource 有点蠢。

@flycash flycash changed the title 分库分表: 排序merger的nullable数据的支持(wip) 分库分表: 排序merger的nullable数据的支持 May 5, 2023
@flycash
Copy link
Contributor

flycash commented May 5, 2023

@longyue0521 可以再看看,没问题就直接合并了。

@longyue0521
Copy link
Collaborator

@longyue0521 可以再看看,没问题就直接合并了。

好的

internal/merger/internal/errs/error.go Outdated Show resolved Hide resolved
internal/merger/sortmerger/heap_test.go Outdated Show resolved Hide resolved
internal/merger/sortmerger/heap_test.go Outdated Show resolved Hide resolved
internal/merger/sortmerger/merger_test.go Outdated Show resolved Hide resolved
internal/merger/sortmerger/merger_test.go Show resolved Hide resolved
internal/merger/utils/convert_assign_test.go Show resolved Hide resolved
internal/merger/sortmerger/merger_test.go Outdated Show resolved Hide resolved
@longyue0521 longyue0521 merged commit d7954c4 into ecodeclub:dev May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants