Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set latest version, whether it's a pre-release or not #419

Merged
merged 1 commit into from
Feb 15, 2022

Conversation

amvanbaren
Copy link
Contributor

@amvanbaren amvanbaren commented Feb 11, 2022

Set extension.latest, whether it's a pre-release or not. It fixes #410 (comment)

Testing steps:

  • Create namespace
  • Publish a pre-release version for a new extension.
  • Check that latest_id points to the pre-release: SELECT e.name, ev.version, ev.pre_release FROM extension e JOIN extension_version ev ON ev.id = e.latest_id. On gitpod you can use the psql CLI tool to execute queries.
  • Publish a newer regular version for the same extension, use the same query to verify that latest now points to the newer regular version.
  • Finally, publish a newer pre-release version and again verify that latest points to the pre-release.
  • Now you can also delete each version one at a time in reverse order and again check that latest is updated.

@akosyakov
Copy link
Member

@jeanp413 @filiptronicek Could you review it please? 🙏 Please make sure that both OpenVSCode Server stable and insiders behave the same way like VS Code behaves against MS Marketplace.

Also if you can document how to test it here 🙏

@filiptronicek
Copy link
Member

Related: #423

@jeanp413
Copy link
Contributor

jeanp413 commented Feb 14, 2022

@amvanbaren we tested it and it's working now in vscode desktop and openvscode server 👍
We found one issue #423 in which the preview badge is always showing when an extension has a pre-release, that should not be the case.

@amvanbaren amvanbaren merged commit b8b65e4 into eclipse:master Feb 15, 2022
amvanbaren added a commit to EclipseFdn/open-vsx.org that referenced this pull request May 22, 2022
eclipse/openvsx#457
eclipse/openvsx#434
eclipse/openvsx#429
eclipse/openvsx#443
eclipse/openvsx#435
eclipse/openvsx#442
eclipse/openvsx#406
eclipse/openvsx#433
eclipse/openvsx#424
[feat: Add support for X-Forwarded-Prefix](eclipse/openvsx@ea2cde9)
eclipse/openvsx#419
eclipse/openvsx#421
eclipse/openvsx#422
eclipse/openvsx#410

Dependabot updates:
[Bump ajv from 6.12.2 to 6.12.6 in /webui](eclipse/openvsx@f475efa)
[Bump follow-redirects from 1.14.7 to 1.14.8 in /cli](eclipse/openvsx@4f8445c)
[Bump pathval from 1.1.0 to 1.1.1 in /webui](eclipse/openvsx@a477256)
[Bump simple-get from 3.1.0 to 3.1.1 in /cli](eclipse/openvsx@2a2d537)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants