-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement target platform #406
Conversation
a7d7d5c
to
7b6714b
Compare
@benoitf Can you review/test whether the DatabaseSearchService still works as expected? |
Hello @amvanbaren I tried by grabbing vsix files from https://marketplace.visualstudio.com/items?itemName=joaomoreno.vscode-platform-specific-sample for different arch like darwin_x64 and darwin_arm64 Then published them with
Then searching the file for platform 'darwin_x64' I got
which is
|
bc35f35
to
46c45f8
Compare
@amvanbaren It would be nice if you specify how to test and to what pay attention. I will encourage team members from Gitpod to provide reviews but they need some pointers. It is generally is a good practice to document testing steps though. |
Fair point, especially for this PR. cli
webui
server
other
|
Hello @amvanbaren if I publish an extension using a specific target like the one from https://marketplace.visualstudio.com/items?itemName=joaomoreno.vscode-platform-specific-sample for darwin_x64, then I publish it When searching for extension like
while if I search on the marketplace (just replacing the endpoint), I have response
(I tested using elasticsearch or database search) |
@benoitf I've updated the PR. Search endpoints no longer assume the default target platform, but instead include all target platforms. |
b690d12
to
da02e1b
Compare
@filiptronicek and me will take a look at this on Thursday |
0ee1e47
to
f1462b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We tried publishing joaomoreno.vscode-platform-specific-sample, specifically three different platform-specific types of one version. After we published it, in the WebUI we just get an Extension not found
page upon visiting it (it is listed on the home page).
Using the query for the non-vscode endpoint returns the correct response (or it seems like it 😄): it responds with three different extensions (MS Marketplace only responds with one extension, an array for each version which contains the platforms).
curl http://localhost:8080/api/-/query -H 'accept: application/json' -H 'content-type: application/json' -d '{ "extensionId": "joaomoreno.vscode-platform-specific-sample" }' | jq .
But when VS Code tries to fetch it, there is an error (org.jooq.exception.TooManyRowsException: Cursor returned more than one result
). You can reproduce that with the following curl command:
curl http://localhost:8080/vscode/gallery/extensionquery -H 'accept: application/json;api-version=3.0-preview.1' -H 'content-type: application/json' -d '{"filters":[{"criteria":[{"filterType":7,"value":"joaomoreno.vscode-platform-specific-sample"},{"filterType":8,"value":"Microsoft.VisualStudio.Code"},{"filterType":12,"value":"4096"}],"pageNumber":1,"pageSize":1,"sortBy":0,"sortOrder":0}],"assetTypes":[],"flags":950}' | jq .
A successful response from Microsoft Marketplace should look like this
Disclaimer: it's long 😄
{
"results": [
{
"extensions": [
{
"publisher": {
"publisherId": "49e3db42-49c1-4e8f-9e0b-c7577efa9feb",
"publisherName": "joaomoreno",
"displayName": "João Moreno",
"flags": "verified",
"domain": null,
"isDomainVerified": false
},
"extensionId": "4fc4f990-1b34-4ee1-a016-17405bbc4c40",
"extensionName": "vscode-platform-specific-sample",
"displayName": "Platform Specific Sample",
"flags": "validated, public",
"lastUpdated": "2021-09-10T09:35:45.573Z",
"publishedDate": "2021-07-20T20:56:12.027Z",
"releaseDate": "2021-07-20T20:56:12.027Z",
"shortDescription": "VS Code platform specific extension sample",
"versions": [
{
"version": "1.15.0",
"targetPlatform": "linux-armhf",
"flags": "validated",
"lastUpdated": "2021-09-10T09:35:45.57Z",
"files": [
{
"assetType": "Microsoft.VisualStudio.Code.Manifest",
"source": "https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.15.0/1631266270314/Microsoft.VisualStudio.Code.Manifest"
},
{
"assetType": "Microsoft.VisualStudio.Services.Content.Details",
"source": "https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.15.0/1631266270314/Microsoft.VisualStudio.Services.Content.Details"
},
{
"assetType": "Microsoft.VisualStudio.Services.Content.License",
"source": "https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.15.0/1631266270314/Microsoft.VisualStudio.Services.Content.License"
},
{
"assetType": "Microsoft.VisualStudio.Services.VsixManifest",
"source": "https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.15.0/1631266270314/Microsoft.VisualStudio.Services.VsixManifest"
},
{
"assetType": "Microsoft.VisualStudio.Services.VSIXPackage",
"source": "https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.15.0/1631266270314/Microsoft.VisualStudio.Services.VSIXPackage"
}
],
"properties": [
{
"key": "Microsoft.VisualStudio.Services.Links.Getstarted",
"value": "https://github.com/microsoft/vscode-platform-specific-sample.git"
},
{
"key": "Microsoft.VisualStudio.Services.Links.Support",
"value": "https://github.com/microsoft/vscode-platform-specific-sample/issues"
},
{
"key": "Microsoft.VisualStudio.Services.Links.Learn",
"value": "https://github.com/microsoft/vscode-platform-specific-sample#readme"
},
{
"key": "Microsoft.VisualStudio.Services.Links.Source",
"value": "https://github.com/microsoft/vscode-platform-specific-sample.git"
},
{
"key": "Microsoft.VisualStudio.Services.Links.GitHub",
"value": "https://github.com/microsoft/vscode-platform-specific-sample.git"
},
{
"key": "Microsoft.VisualStudio.Code.Engine",
"value": "^1.58.0"
},
{
"key": "Microsoft.VisualStudio.Services.GitHubFlavoredMarkdown",
"value": "true"
},
{
"key": "Microsoft.VisualStudio.Code.ExtensionDependencies",
"value": ""
},
{
"key": "Microsoft.VisualStudio.Code.ExtensionPack",
"value": ""
},
{
"key": "Microsoft.VisualStudio.Code.LocalizedLanguages",
"value": ""
},
{
"key": "Microsoft.VisualStudio.Code.ExtensionKind",
"value": "workspace"
}
],
"assetUri": "https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.15.0/1631266270314",
"fallbackAssetUri": "https://joaomoreno.gallery.vsassets.io/_apis/public/gallery/publisher/joaomoreno/extension/vscode-platform-specific-sample/1.15.0/assetbyname"
},
{
"version": "1.15.0",
"targetPlatform": "win32-ia32",
"flags": "validated",
"lastUpdated": "2021-09-10T09:35:36.383Z",
"files": [
{
"assetType": "Microsoft.VisualStudio.Code.Manifest",
"source": "https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.15.0/1631266273792/Microsoft.VisualStudio.Code.Manifest"
},
{
"assetType": "Microsoft.VisualStudio.Services.Content.Details",
"source": "https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.15.0/1631266273792/Microsoft.VisualStudio.Services.Content.Details"
},
{
"assetType": "Microsoft.VisualStudio.Services.Content.License",
"source": "https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.15.0/1631266273792/Microsoft.VisualStudio.Services.Content.License"
},
{
"assetType": "Microsoft.VisualStudio.Services.VsixManifest",
"source": "https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.15.0/1631266273792/Microsoft.VisualStudio.Services.VsixManifest"
},
{
"assetType": "Microsoft.VisualStudio.Services.VSIXPackage",
"source": "https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.15.0/1631266273792/Microsoft.VisualStudio.Services.VSIXPackage"
}
],
"properties": [
{
"key": "Microsoft.VisualStudio.Services.Links.Getstarted",
"value": "https://github.com/microsoft/vscode-platform-specific-sample.git"
},
{
"key": "Microsoft.VisualStudio.Services.Links.Support",
"value": "https://github.com/microsoft/vscode-platform-specific-sample/issues"
},
{
"key": "Microsoft.VisualStudio.Services.Links.Learn",
"value": "https://github.com/microsoft/vscode-platform-specific-sample#readme"
},
{
"key": "Microsoft.VisualStudio.Services.Links.Source",
"value": "https://github.com/microsoft/vscode-platform-specific-sample.git"
},
{
"key": "Microsoft.VisualStudio.Services.Links.GitHub",
"value": "https://github.com/microsoft/vscode-platform-specific-sample.git"
},
{
"key": "Microsoft.VisualStudio.Code.Engine",
"value": "^1.58.0"
},
{
"key": "Microsoft.VisualStudio.Services.GitHubFlavoredMarkdown",
"value": "true"
},
{
"key": "Microsoft.VisualStudio.Code.ExtensionDependencies",
"value": ""
},
{
"key": "Microsoft.VisualStudio.Code.ExtensionPack",
"value": ""
},
{
"key": "Microsoft.VisualStudio.Code.LocalizedLanguages",
"value": ""
},
{
"key": "Microsoft.VisualStudio.Code.ExtensionKind",
"value": "workspace"
}
],
"assetUri": "https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.15.0/1631266273792",
"fallbackAssetUri": "https://joaomoreno.gallery.vsassets.io/_apis/public/gallery/publisher/joaomoreno/extension/vscode-platform-specific-sample/1.15.0/assetbyname"
},
{
"version": "1.15.0",
"targetPlatform": "darwin-arm64",
"flags": "validated",
"lastUpdated": "2021-09-10T09:33:43.273Z",
"files": [
{
"assetType": "Microsoft.VisualStudio.Code.Manifest",
"source": "https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.15.0/1631266272772/Microsoft.VisualStudio.Code.Manifest"
},
{
"assetType": "Microsoft.VisualStudio.Services.Content.Details",
"source": "https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.15.0/1631266272772/Microsoft.VisualStudio.Services.Content.Details"
},
{
"assetType": "Microsoft.VisualStudio.Services.Content.License",
"source": "https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.15.0/1631266272772/Microsoft.VisualStudio.Services.Content.License"
},
{
"assetType": "Microsoft.VisualStudio.Services.VsixManifest",
"source": "https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.15.0/1631266272772/Microsoft.VisualStudio.Services.VsixManifest"
},
{
"assetType": "Microsoft.VisualStudio.Services.VSIXPackage",
"source": "https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.15.0/1631266272772/Microsoft.VisualStudio.Services.VSIXPackage"
}
],
"properties": [
{
"key": "Microsoft.VisualStudio.Services.Links.Getstarted",
"value": "https://github.com/microsoft/vscode-platform-specific-sample.git"
},
{
"key": "Microsoft.VisualStudio.Services.Links.Support",
"value": "https://github.com/microsoft/vscode-platform-specific-sample/issues"
},
{
"key": "Microsoft.VisualStudio.Services.Links.Learn",
"value": "https://github.com/microsoft/vscode-platform-specific-sample#readme"
},
{
"key": "Microsoft.VisualStudio.Services.Links.Source",
"value": "https://github.com/microsoft/vscode-platform-specific-sample.git"
},
{
"key": "Microsoft.VisualStudio.Services.Links.GitHub",
"value": "https://github.com/microsoft/vscode-platform-specific-sample.git"
},
{
"key": "Microsoft.VisualStudio.Code.Engine",
"value": "^1.58.0"
},
{
"key": "Microsoft.VisualStudio.Services.GitHubFlavoredMarkdown",
"value": "true"
},
{
"key": "Microsoft.VisualStudio.Code.ExtensionDependencies",
"value": ""
},
{
"key": "Microsoft.VisualStudio.Code.ExtensionPack",
"value": ""
},
{
"key": "Microsoft.VisualStudio.Code.LocalizedLanguages",
"value": ""
},
{
"key": "Microsoft.VisualStudio.Code.ExtensionKind",
"value": "workspace"
}
],
"assetUri": "https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.15.0/1631266272772",
"fallbackAssetUri": "https://joaomoreno.gallery.vsassets.io/_apis/public/gallery/publisher/joaomoreno/extension/vscode-platform-specific-sample/1.15.0/assetbyname"
},
{
"version": "1.15.0",
"targetPlatform": "win32-x64",
"flags": "validated",
"lastUpdated": "2021-09-10T09:33:41.317Z",
"files": [
{
"assetType": "Microsoft.VisualStudio.Code.Manifest",
"source": "https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.15.0/1631266271584/Microsoft.VisualStudio.Code.Manifest"
},
{
"assetType": "Microsoft.VisualStudio.Services.Content.Details",
"source": "https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.15.0/1631266271584/Microsoft.VisualStudio.Services.Content.Details"
},
{
"assetType": "Microsoft.VisualStudio.Services.Content.License",
"source": "https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.15.0/1631266271584/Microsoft.VisualStudio.Services.Content.License"
},
{
"assetType": "Microsoft.VisualStudio.Services.VsixManifest",
"source": "https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.15.0/1631266271584/Microsoft.VisualStudio.Services.VsixManifest"
},
{
"assetType": "Microsoft.VisualStudio.Services.VSIXPackage",
"source": "https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.15.0/1631266271584/Microsoft.VisualStudio.Services.VSIXPackage"
}
],
"properties": [
{
"key": "Microsoft.VisualStudio.Services.Links.Getstarted",
"value": "https://github.com/microsoft/vscode-platform-specific-sample.git"
},
{
"key": "Microsoft.VisualStudio.Services.Links.Support",
"value": "https://github.com/microsoft/vscode-platform-specific-sample/issues"
},
{
"key": "Microsoft.VisualStudio.Services.Links.Learn",
"value": "https://github.com/microsoft/vscode-platform-specific-sample#readme"
},
{
"key": "Microsoft.VisualStudio.Services.Links.Source",
"value": "https://github.com/microsoft/vscode-platform-specific-sample.git"
},
{
"key": "Microsoft.VisualStudio.Services.Links.GitHub",
"value": "https://github.com/microsoft/vscode-platform-specific-sample.git"
},
{
"key": "Microsoft.VisualStudio.Code.Engine",
"value": "^1.58.0"
},
{
"key": "Microsoft.VisualStudio.Services.GitHubFlavoredMarkdown",
"value": "true"
},
{
"key": "Microsoft.VisualStudio.Code.ExtensionDependencies",
"value": ""
},
{
"key": "Microsoft.VisualStudio.Code.ExtensionPack",
"value": ""
},
{
"key": "Microsoft.VisualStudio.Code.LocalizedLanguages",
"value": ""
},
{
"key": "Microsoft.VisualStudio.Code.ExtensionKind",
"value": "workspace"
}
],
"assetUri": "https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.15.0/1631266271584",
"fallbackAssetUri": "https://joaomoreno.gallery.vsassets.io/_apis/public/gallery/publisher/joaomoreno/extension/vscode-platform-specific-sample/1.15.0/assetbyname"
},
{
"version": "1.15.0",
"targetPlatform": "darwin-x64",
"flags": "validated",
"lastUpdated": "2021-09-10T09:33:39.727Z",
"files": [
{
"assetType": "Microsoft.VisualStudio.Code.Manifest",
"source": "https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.15.0/1631266269426/Microsoft.VisualStudio.Code.Manifest"
},
{
"assetType": "Microsoft.VisualStudio.Services.Content.Details",
"source": "https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.15.0/1631266269426/Microsoft.VisualStudio.Services.Content.Details"
},
{
"assetType": "Microsoft.VisualStudio.Services.Content.License",
"source": "https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.15.0/1631266269426/Microsoft.VisualStudio.Services.Content.License"
},
{
"assetType": "Microsoft.VisualStudio.Services.VsixManifest",
"source": "https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.15.0/1631266269426/Microsoft.VisualStudio.Services.VsixManifest"
},
{
"assetType": "Microsoft.VisualStudio.Services.VSIXPackage",
"source": "https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.15.0/1631266269426/Microsoft.VisualStudio.Services.VSIXPackage"
}
],
"properties": [
{
"key": "Microsoft.VisualStudio.Services.Links.Getstarted",
"value": "https://github.com/microsoft/vscode-platform-specific-sample.git"
},
{
"key": "Microsoft.VisualStudio.Services.Links.Support",
"value": "https://github.com/microsoft/vscode-platform-specific-sample/issues"
},
{
"key": "Microsoft.VisualStudio.Services.Links.Learn",
"value": "https://github.com/microsoft/vscode-platform-specific-sample#readme"
},
{
"key": "Microsoft.VisualStudio.Services.Links.Source",
"value": "https://github.com/microsoft/vscode-platform-specific-sample.git"
},
{
"key": "Microsoft.VisualStudio.Services.Links.GitHub",
"value": "https://github.com/microsoft/vscode-platform-specific-sample.git"
},
{
"key": "Microsoft.VisualStudio.Code.Engine",
"value": "^1.58.0"
},
{
"key": "Microsoft.VisualStudio.Services.GitHubFlavoredMarkdown",
"value": "true"
},
{
"key": "Microsoft.VisualStudio.Code.ExtensionDependencies",
"value": ""
},
{
"key": "Microsoft.VisualStudio.Code.ExtensionPack",
"value": ""
},
{
"key": "Microsoft.VisualStudio.Code.LocalizedLanguages",
"value": ""
},
{
"key": "Microsoft.VisualStudio.Code.ExtensionKind",
"value": "workspace"
}
],
"assetUri": "https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.15.0/1631266269426",
"fallbackAssetUri": "https://joaomoreno.gallery.vsassets.io/_apis/public/gallery/publisher/joaomoreno/extension/vscode-platform-specific-sample/1.15.0/assetbyname"
},
{
"version": "1.15.0",
"targetPlatform": "win32-arm64",
"flags": "validated",
"lastUpdated": "2021-09-10T09:33:38.72Z",
"files": [
{
"assetType": "Microsoft.VisualStudio.Code.Manifest",
"source": "https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.15.0/1631266268694/Microsoft.VisualStudio.Code.Manifest"
},
{
"assetType": "Microsoft.VisualStudio.Services.Content.Details",
"source": "https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.15.0/1631266268694/Microsoft.VisualStudio.Services.Content.Details"
},
{
"assetType": "Microsoft.VisualStudio.Services.Content.License",
"source": "https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.15.0/1631266268694/Microsoft.VisualStudio.Services.Content.License"
},
{
"assetType": "Microsoft.VisualStudio.Services.VsixManifest",
"source": "https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.15.0/1631266268694/Microsoft.VisualStudio.Services.VsixManifest"
},
{
"assetType": "Microsoft.VisualStudio.Services.VSIXPackage",
"source": "https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.15.0/1631266268694/Microsoft.VisualStudio.Services.VSIXPackage"
}
],
"properties": [
{
"key": "Microsoft.VisualStudio.Services.Links.Getstarted",
"value": "https://github.com/microsoft/vscode-platform-specific-sample.git"
},
{
"key": "Microsoft.VisualStudio.Services.Links.Support",
"value": "https://github.com/microsoft/vscode-platform-specific-sample/issues"
},
{
"key": "Microsoft.VisualStudio.Services.Links.Learn",
"value": "https://github.com/microsoft/vscode-platform-specific-sample#readme"
},
{
"key": "Microsoft.VisualStudio.Services.Links.Source",
"value": "https://github.com/microsoft/vscode-platform-specific-sample.git"
},
{
"key": "Microsoft.VisualStudio.Services.Links.GitHub",
"value": "https://github.com/microsoft/vscode-platform-specific-sample.git"
},
{
"key": "Microsoft.VisualStudio.Code.Engine",
"value": "^1.58.0"
},
{
"key": "Microsoft.VisualStudio.Services.GitHubFlavoredMarkdown",
"value": "true"
},
{
"key": "Microsoft.VisualStudio.Code.ExtensionDependencies",
"value": ""
},
{
"key": "Microsoft.VisualStudio.Code.ExtensionPack",
"value": ""
},
{
"key": "Microsoft.VisualStudio.Code.LocalizedLanguages",
"value": ""
},
{
"key": "Microsoft.VisualStudio.Code.ExtensionKind",
"value": "workspace"
}
],
"assetUri": "https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.15.0/1631266268694",
"fallbackAssetUri": "https://joaomoreno.gallery.vsassets.io/_apis/public/gallery/publisher/joaomoreno/extension/vscode-platform-specific-sample/1.15.0/assetbyname"
},
{
"version": "1.15.0",
"targetPlatform": "alpine-x64",
"flags": "validated",
"lastUpdated": "2021-09-10T09:33:38.207Z",
"files": [
{
"assetType": "Microsoft.VisualStudio.Code.Manifest",
"source": "https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.15.0/1631266275159/Microsoft.VisualStudio.Code.Manifest"
},
{
"assetType": "Microsoft.VisualStudio.Services.Content.Details",
"source": "https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.15.0/1631266275159/Microsoft.VisualStudio.Services.Content.Details"
},
{
"assetType": "Microsoft.VisualStudio.Services.Content.License",
"source": "https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.15.0/1631266275159/Microsoft.VisualStudio.Services.Content.License"
},
{
"assetType": "Microsoft.VisualStudio.Services.VsixManifest",
"source": "https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.15.0/1631266275159/Microsoft.VisualStudio.Services.VsixManifest"
},
{
"assetType": "Microsoft.VisualStudio.Services.VSIXPackage",
"source": "https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.15.0/1631266275159/Microsoft.VisualStudio.Services.VSIXPackage"
}
],
"properties": [
{
"key": "Microsoft.VisualStudio.Services.Links.Getstarted",
"value": "https://github.com/microsoft/vscode-platform-specific-sample.git"
},
{
"key": "Microsoft.VisualStudio.Services.Links.Support",
"value": "https://github.com/microsoft/vscode-platform-specific-sample/issues"
},
{
"key": "Microsoft.VisualStudio.Services.Links.Learn",
"value": "https://github.com/microsoft/vscode-platform-specific-sample#readme"
},
{
"key": "Microsoft.VisualStudio.Services.Links.Source",
"value": "https://github.com/microsoft/vscode-platform-specific-sample.git"
},
{
"key": "Microsoft.VisualStudio.Services.Links.GitHub",
"value": "https://github.com/microsoft/vscode-platform-specific-sample.git"
},
{
"key": "Microsoft.VisualStudio.Code.Engine",
"value": "^1.58.0"
},
{
"key": "Microsoft.VisualStudio.Services.GitHubFlavoredMarkdown",
"value": "true"
},
{
"key": "Microsoft.VisualStudio.Code.ExtensionDependencies",
"value": ""
},
{
"key": "Microsoft.VisualStudio.Code.ExtensionPack",
"value": ""
},
{
"key": "Microsoft.VisualStudio.Code.LocalizedLanguages",
"value": ""
},
{
"key": "Microsoft.VisualStudio.Code.ExtensionKind",
"value": "workspace"
}
],
"assetUri": "https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.15.0/1631266275159",
"fallbackAssetUri": "https://joaomoreno.gallery.vsassets.io/_apis/public/gallery/publisher/joaomoreno/extension/vscode-platform-specific-sample/1.15.0/assetbyname"
},
{
"version": "1.15.0",
"targetPlatform": "linux-arm64",
"flags": "validated",
"lastUpdated": "2021-09-10T09:33:35.92Z",
"files": [
{
"assetType": "Microsoft.VisualStudio.Code.Manifest",
"source": "https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.15.0/1631266266517/Microsoft.VisualStudio.Code.Manifest"
},
{
"assetType": "Microsoft.VisualStudio.Services.Content.Details",
"source": "https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.15.0/1631266266517/Microsoft.VisualStudio.Services.Content.Details"
},
{
"assetType": "Microsoft.VisualStudio.Services.Content.License",
"source": "https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.15.0/1631266266517/Microsoft.VisualStudio.Services.Content.License"
},
{
"assetType": "Microsoft.VisualStudio.Services.VsixManifest",
"source": "https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.15.0/1631266266517/Microsoft.VisualStudio.Services.VsixManifest"
},
{
"assetType": "Microsoft.VisualStudio.Services.VSIXPackage",
"source": "https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.15.0/1631266266517/Microsoft.VisualStudio.Services.VSIXPackage"
}
],
"properties": [
{
"key": "Microsoft.VisualStudio.Services.Links.Getstarted",
"value": "https://github.com/microsoft/vscode-platform-specific-sample.git"
},
{
"key": "Microsoft.VisualStudio.Services.Links.Support",
"value": "https://github.com/microsoft/vscode-platform-specific-sample/issues"
},
{
"key": "Microsoft.VisualStudio.Services.Links.Learn",
"value": "https://github.com/microsoft/vscode-platform-specific-sample#readme"
},
{
"key": "Microsoft.VisualStudio.Services.Links.Source",
"value": "https://github.com/microsoft/vscode-platform-specific-sample.git"
},
{
"key": "Microsoft.VisualStudio.Services.Links.GitHub",
"value": "https://github.com/microsoft/vscode-platform-specific-sample.git"
},
{
"key": "Microsoft.VisualStudio.Code.Engine",
"value": "^1.58.0"
},
{
"key": "Microsoft.VisualStudio.Services.GitHubFlavoredMarkdown",
"value": "true"
},
{
"key": "Microsoft.VisualStudio.Code.ExtensionDependencies",
"value": ""
},
{
"key": "Microsoft.VisualStudio.Code.ExtensionPack",
"value": ""
},
{
"key": "Microsoft.VisualStudio.Code.LocalizedLanguages",
"value": ""
},
{
"key": "Microsoft.VisualStudio.Code.ExtensionKind",
"value": "workspace"
}
],
"assetUri": "https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.15.0/1631266266517",
"fallbackAssetUri": "https://joaomoreno.gallery.vsassets.io/_apis/public/gallery/publisher/joaomoreno/extension/vscode-platform-specific-sample/1.15.0/assetbyname"
},
{
"version": "1.15.0",
"targetPlatform": "linux-x64",
"flags": "validated",
"lastUpdated": "2021-09-10T09:33:25.437Z",
"files": [
{
"assetType": "Microsoft.VisualStudio.Code.Manifest",
"source": "https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.15.0/1631266267773/Microsoft.VisualStudio.Code.Manifest"
},
{
"assetType": "Microsoft.VisualStudio.Services.Content.Details",
"source": "https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.15.0/1631266267773/Microsoft.VisualStudio.Services.Content.Details"
},
{
"assetType": "Microsoft.VisualStudio.Services.Content.License",
"source": "https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.15.0/1631266267773/Microsoft.VisualStudio.Services.Content.License"
},
{
"assetType": "Microsoft.VisualStudio.Services.VsixManifest",
"source": "https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.15.0/1631266267773/Microsoft.VisualStudio.Services.VsixManifest"
},
{
"assetType": "Microsoft.VisualStudio.Services.VSIXPackage",
"source": "https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.15.0/1631266267773/Microsoft.VisualStudio.Services.VSIXPackage"
}
],
"properties": [
{
"key": "Microsoft.VisualStudio.Services.Links.Getstarted",
"value": "https://github.com/microsoft/vscode-platform-specific-sample.git"
},
{
"key": "Microsoft.VisualStudio.Services.Links.Support",
"value": "https://github.com/microsoft/vscode-platform-specific-sample/issues"
},
{
"key": "Microsoft.VisualStudio.Services.Links.Learn",
"value": "https://github.com/microsoft/vscode-platform-specific-sample#readme"
},
{
"key": "Microsoft.VisualStudio.Services.Links.Source",
"value": "https://github.com/microsoft/vscode-platform-specific-sample.git"
},
{
"key": "Microsoft.VisualStudio.Services.Links.GitHub",
"value": "https://github.com/microsoft/vscode-platform-specific-sample.git"
},
{
"key": "Microsoft.VisualStudio.Code.Engine",
"value": "^1.58.0"
},
{
"key": "Microsoft.VisualStudio.Services.GitHubFlavoredMarkdown",
"value": "true"
},
{
"key": "Microsoft.VisualStudio.Code.ExtensionDependencies",
"value": ""
},
{
"key": "Microsoft.VisualStudio.Code.ExtensionPack",
"value": ""
},
{
"key": "Microsoft.VisualStudio.Code.LocalizedLanguages",
"value": ""
},
{
"key": "Microsoft.VisualStudio.Code.ExtensionKind",
"value": "workspace"
}
],
"assetUri": "https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.15.0/1631266267773",
"fallbackAssetUri": "https://joaomoreno.gallery.vsassets.io/_apis/public/gallery/publisher/joaomoreno/extension/vscode-platform-specific-sample/1.15.0/assetbyname"
},
{
"version": "1.14.0",
"targetPlatform": "web",
"flags": "validated",
"lastUpdated": "2021-09-10T09:31:22.743Z",
"files": [
{
"assetType": "Microsoft.VisualStudio.Code.Manifest",
"source": "https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.14.0/1631266136274/Microsoft.VisualStudio.Code.Manifest"
},
{
"assetType": "Microsoft.VisualStudio.Services.Content.Details",
"source": "https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.14.0/1631266136274/Microsoft.VisualStudio.Services.Content.Details"
},
{
"assetType": "Microsoft.VisualStudio.Services.Content.License",
"source": "https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.14.0/1631266136274/Microsoft.VisualStudio.Services.Content.License"
},
{
"assetType": "Microsoft.VisualStudio.Services.VsixManifest",
"source": "https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.14.0/1631266136274/Microsoft.VisualStudio.Services.VsixManifest"
},
{
"assetType": "Microsoft.VisualStudio.Services.VSIXPackage",
"source": "https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.14.0/1631266136274/Microsoft.VisualStudio.Services.VSIXPackage"
}
],
"properties": [
{
"key": "Microsoft.VisualStudio.Services.Links.Getstarted",
"value": "https://github.com/microsoft/vscode-platform-specific-sample.git"
},
{
"key": "Microsoft.VisualStudio.Services.Links.Support",
"value": "https://github.com/microsoft/vscode-platform-specific-sample/issues"
},
{
"key": "Microsoft.VisualStudio.Services.Links.Learn",
"value": "https://github.com/microsoft/vscode-platform-specific-sample#readme"
},
{
"key": "Microsoft.VisualStudio.Services.Links.Source",
"value": "https://github.com/microsoft/vscode-platform-specific-sample.git"
},
{
"key": "Microsoft.VisualStudio.Services.Links.GitHub",
"value": "https://github.com/microsoft/vscode-platform-specific-sample.git"
},
{
"key": "Microsoft.VisualStudio.Code.Engine",
"value": "^1.58.0"
},
{
"key": "Microsoft.VisualStudio.Services.GitHubFlavoredMarkdown",
"value": "true"
},
{
"key": "Microsoft.VisualStudio.Code.ExtensionDependencies",
"value": ""
},
{
"key": "Microsoft.VisualStudio.Code.ExtensionPack",
"value": ""
},
{
"key": "Microsoft.VisualStudio.Code.LocalizedLanguages",
"value": ""
},
{
"key": "Microsoft.VisualStudio.Code.ExtensionKind",
"value": "workspace,web"
}
],
"assetUri": "https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.14.0/1631266136274",
"fallbackAssetUri": "https://joaomoreno.gallery.vsassets.io/_apis/public/gallery/publisher/joaomoreno/extension/vscode-platform-specific-sample/1.14.0/assetbyname"
},
{
"version": "1.2.1",
"flags": "validated",
"lastUpdated": "2021-07-21T12:42:06.64Z",
"files": [
{
"assetType": "Microsoft.VisualStudio.Code.Manifest",
"source": "https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.2.1/1626871153799/Microsoft.VisualStudio.Code.Manifest"
},
{
"assetType": "Microsoft.VisualStudio.Services.Content.Details",
"source": "https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.2.1/1626871153799/Microsoft.VisualStudio.Services.Content.Details"
},
{
"assetType": "Microsoft.VisualStudio.Services.VsixManifest",
"source": "https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.2.1/1626871153799/Microsoft.VisualStudio.Services.VsixManifest"
},
{
"assetType": "Microsoft.VisualStudio.Services.VSIXPackage",
"source": "https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.2.1/1626871153799/Microsoft.VisualStudio.Services.VSIXPackage"
}
],
"properties": [
{
"key": "Microsoft.VisualStudio.Services.Links.Getstarted",
"value": "https://github.com/joaomoreno/vscode-platform-specific-sample"
},
{
"key": "Microsoft.VisualStudio.Services.Links.Source",
"value": "https://github.com/joaomoreno/vscode-platform-specific-sample"
},
{
"key": "Microsoft.VisualStudio.Services.Links.GitHub",
"value": "https://github.com/joaomoreno/vscode-platform-specific-sample"
},
{
"key": "Microsoft.VisualStudio.Code.Engine",
"value": "^1.58.0"
},
{
"key": "Microsoft.VisualStudio.Services.GitHubFlavoredMarkdown",
"value": "true"
},
{
"key": "Microsoft.VisualStudio.Code.ExtensionDependencies",
"value": ""
},
{
"key": "Microsoft.VisualStudio.Code.ExtensionPack",
"value": ""
},
{
"key": "Microsoft.VisualStudio.Code.LocalizedLanguages",
"value": ""
},
{
"key": "Microsoft.VisualStudio.Code.ExtensionKind",
"value": "workspace"
}
],
"assetUri": "https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.2.1/1626871153799",
"fallbackAssetUri": "https://joaomoreno.gallery.vsassets.io/_apis/public/gallery/publisher/joaomoreno/extension/vscode-platform-specific-sample/1.2.1/assetbyname"
}
],
"categories": [
"Other"
],
"tags": [
"__web_extension"
],
"statistics": [
{
"statisticName": "install",
"value": 91.0
},
{
"statisticName": "trendingdaily",
"value": 0.0
},
{
"statisticName": "trendingmonthly",
"value": 0.0
},
{
"statisticName": "trendingweekly",
"value": 0.0
},
{
"statisticName": "updateCount",
"value": 23.0
},
{
"statisticName": "weightedRating",
"value": 4.4032047293092722
},
{
"statisticName": "downloadCount",
"value": 48.0
}
],
"deploymentType": 0
}
],
"pagingToken": null,
"resultMetadata": [
{
"metadataType": "ResultCount",
"metadataItems": [
{
"name": "TotalCount",
"count": 1
}
]
}
]
}
]
}
@filiptronicek Which MS Marketplace endpoint do you refer to? |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We just tested the PR and there are a couple of things to note:
- In the web UI you can see the extension without errors
- The extension request in VS Code succeeds, but it also tries to fetch the extension manifest and that does not succeed, which means the extension refuses to install.
curl 'http://localhost:8080/vscode/asset/joaomoreno/vscode-platform-specific-sample/darwin-arm64/1.15.0/Microsoft.VisualStudio.Code.Manifest?targetPlatform=darwin-arm64' --HEAD
After that, VS Code tries querying this URL with the parameter of the platform: (it returns the README in markdown), but this argument is only added for platform-specific extensions.
https://joaomoreno.gallerycdn.vsassets.io/extensions/joaomoreno/vscode-platform-specific-sample/1.15.0/1631266267773/Microsoft.VisualStudio.Services.Content.Details?targetPlatform=linux-x64
Also note that there is also a target platform just named "web".
cdf09ed
to
8f18e33
Compare
@filiptronicek I've changed the The I've rebased the branch to integrate pre-release functionality. |
I just tried again and it looks like it will install and do compatibility checks just fine, including the download buttons! We will take a deeper look with @jeanp413 later, thanks for the quick fix, @amvanbaren! |
Well check here what we tested sucessfully: cli
webui
admin remove extension:
server
VSCodeAdapter:
RegistryAPI:do existing endpoints still work as expected in theia or gitpod?
do new endpoints also work?
other
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Today we looked over this again and made a checklist for tracking progress with what we tested.
We found that when you publish an extension as a platform specific one and then in the next version of it you publish it as universal (no target
flag), you cannot go back to the page containing the previous version, only a blank screen. After that, we published a bumped Linux only version (linux-x64
) and that version got published, put in the database but did not show in the UI (or in the API, meaning it would be good to always show latest version it doesn't matter if there is only one arm64 package, always show latest, but when querying for a specific platform, show latest compatible). Then we published the same version as universal and now we have it available on the web UI.
After all of this we tried downloading a vsix
from an extension without the --target
flag, but although it has an Universal version, it did not return anything 😕.
/workspace/openvsx/cli/lib/ovsx get joaomoreno.vscode-platform-specific-sample -v 1.15.0 -o /workspace/
Produces ❌ Invalid Version: latest
A nitpick: the downloaded names for packages from the previous command have a different naming convention than the Microsoft ones: maybe it would be good to change it to {id}-{version}@{platform}.vsix
|
Extensions can be removed in the webui admin dashboard.
This can be tested when the server is deployed to staging.
By getting |
My TODO list:
|
be71a54
to
a353532
Compare
Let's review again tomorrow, @jeanp413? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We reviewed again today and found the following:
- downloading works but the file is not URL-decoded, which means it is not
id-version@target
, butid-version%40target
- the
ovsx get
command always downloads the latest published target file, which means when we publish a Linux package and then macOS and then download it with theget
command, we get the macOS version. We figured with @jeanp413 that it should always default to downloadinguniversal
and if it is not there and no--target
is specified it should error out.- this is probably also tied into the bug where if you query with
ovsx get --metadata extension.id
it putsdarwin-arm64
as thetagetPlatform
even though thedownload
section has bothlinux-x64
as well asdarwin-arm64
release assets.
- this is probably also tied into the bug where if you query with
- also, this may not be a bug at all, but when publishing a
universal
version of an extension and then seeing its metadata via the cli, it returns its download link indexed by an empty string, which is something I haven't seen before 😄:
"downloads": {
"": "http://localhost:8080/api/joaomoreno/vscode-platform-specific-sample/1.15.0/file/joaomoreno.vscode-platform-specific-sample-1.15.0.vsix",
"linux-x64": "http://localhost:8080/api/joaomoreno/vscode-platform-specific-sample/linux-x64/1.15.0/file/joaomoreno.vscode-platform-specific-sample-1.15.0%40linux-x64.vsix",
"darwin-arm64": "http://localhost:8080/api/joaomoreno/vscode-platform-specific-sample/darwin-arm64/1.15.0/file/joaomoreno.vscode-platform-specific-sample-1.15.0%40darwin-arm64.vsix"
}
In addition, could you (@amvanbaren) please instruct us how to see the reports in the admin dashboard? We always got a blank page with a 200-status code. Should we try to view it in the browser or curl
it?
Ok, I'll add URL decoding to the download file name in the get command.
Ok, If --target isn't specified, then universal will be used as target
Yes, I decided to use an empty string as targetPlatform throughout the server for backward compatibility. I'll check if there's still a good reason to use an empty string, if not I'll change it to 'universal'.
You can use curl to view the admin report:
TODO:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the issues, @amvanbaren! I just took a look, here are my thoughts:
- awesome that the
ovsx get
now defaults to the universal target, but I think the new error message style is a bit weirdly phrased:
❌ Extension not found: joaomoreno.vscode-platform-specific-sample for universal
I would suggest maybe something like
❌ Package not found: joaomoreno.vscode-platform-specific-sample ({platform})
Because the extension does exist, but no corresponding packaged asset exists for the selected platform. I would be ok though with this being as is.
💡 idea (non-blocking): @amvanbaren do you think it would make sense to respond to /api/{namespace}/{extension}/universal
with a 301 Moved Permanently
or 308 Permanent Redirect
and redirect to /api/{namespace}/{extension}/
? (But maybe this is a bad idea and would be inconsistent with MS, but could not find a way to look at this)
🐛 bug (blocking): in the web view, I found that the download links for extensions are malformed, this is one I just got for Apple Silicon:
http://localhost:3000/extension/joaomoreno/localhost:8080/api/joaomoreno/vscode-platform-specific-sample/linux-x64/1.15.0/file/joaomoreno.vscode-platform-specific-sample-1.15.0%40linux-x64.vsix
Note: this only happens with the download dropdown, if there is only one download link (platform independent) the link works fine.
I believe this is displayed here, but I'm not sure where exactly the link is created:
The An example: The I'll fix the other issues. |
a513da5
to
2bc6807
Compare
The CLI calls the |
cli/README.md
Outdated
@@ -39,7 +39,7 @@ You can use `ovsx` for downloading extensions from an Open VSX instance. Extensi | |||
|
|||
Variants: | |||
* `ovsx get <extension>` | |||
downloads an extension and saves it in a file as specified in its download URL (usually in the format `namespace.extension-version.vsix`) in the current working directory. | |||
downloads an extension and saves it in a file as specified in its download URL (usually in the format `namespace.extension-version@target.vsix`) in the current working directory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we mention here that for most extension there will be no @target
part? I know it will make the description quite a bit lengthier, but it is
- optional
- not used as much and could confuse some users. We can point to the VS Code docs about the feature [1]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR LGTM, just one small inconsistency with the MS Marketplace:
If you publish a stable version of for example win32-x64
and then a pre-release with another platform (e.g. linux-x64), the pre-release flag will be basically ignored. Could we perhaps add a warning in the console about this?
It is an inconsistency, but that does not mean I want to have it the way that MS has it 😄, as they just ignore that you ever published that pre-release and don't even treat it as a release, so you couldn't download the linux-x64
from the example I gave.
Is this when you publish 0.1.0 for win32-x64 and then 0.1.0 pre-release for linux-x64? Maybe we should add a constraint like this:
|
@amvanbaren sorry for not mentioning that 🙏, it was the former - the versions were the same.
I think although that would make sense and would eliminate the issue, there will be some extensions which break sooner or later. It would be ideal if all extensions did what Microsoft recommends, but if Microsoft doesn't disallow it, I think we shouldn't as well. |
Ok, makes sense. Maybe a warning like this: In the console you would then see: |
server/src/main/java/org/eclipse/openvsx/LocalRegistryService.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, I reviewed the latest changes and they work flawlessly.
LGTM ✅
d13f0b1
to
36ef42f
Compare
Just out of curiosity, would something like:
Work for This comes from https://github.com/microsoft/vscode-platform-specific-sample/blob/main/.github/workflows/ci.yml#L74. |
eclipse/openvsx#457 eclipse/openvsx#434 eclipse/openvsx#429 eclipse/openvsx#443 eclipse/openvsx#435 eclipse/openvsx#442 eclipse/openvsx#406 eclipse/openvsx#433 eclipse/openvsx#424 [feat: Add support for X-Forwarded-Prefix](eclipse/openvsx@ea2cde9) eclipse/openvsx#419 eclipse/openvsx#421 eclipse/openvsx#422 eclipse/openvsx#410 Dependabot updates: [Bump ajv from 6.12.2 to 6.12.6 in /webui](eclipse/openvsx@f475efa) [Bump follow-redirects from 1.14.7 to 1.14.8 in /cli](eclipse/openvsx@4f8445c) [Bump pathval from 1.1.0 to 1.1.1 in /webui](eclipse/openvsx@a477256) [Bump simple-get from 3.1.0 to 3.1.1 in /cli](eclipse/openvsx@2a2d537)
Fixes #336
CLI:
publish
andget
commands.web UI:
server: