Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to provide the path to the devfile yaml file when using factory workflow #20607

Closed
benoitf opened this issue Oct 7, 2021 · 3 comments · Fixed by eclipse-che/che-dashboard#385
Assignees
Labels
area/che-server area/factory/dashboard Issues related to factories frontend (che user dashboard side) engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/enhancement A feature request - must adhere to the feature request template. new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes severity/P1 Has a major impact to usage or development of the system.
Milestone

Comments

@benoitf
Copy link
Contributor

benoitf commented Oct 7, 2021

Is your enhancement related to a problem? Please describe

I have a repository having a devfile v1 there.
Then, I want to add devfile v2 in my repository but still have the v1.

I would like to be able to specify the path to my v2 when I'm running in a DevWorkspace instance

Describe the solution you'd like

I would like to be able to specify like devfilePath=devfile.v2 at the end of the URL for factory workflow to switch to different devfiles

Describe alternatives you've considered

N/A but if there are better proposals

Additional context

to have both devfile v1 and v2 in a repository and be able to use for example online instance workspaces.openshift.com and a DevWorkspace instance to load my projects using my devfiles.

Release Notes Text

If the devfile is not at the root of a repository or has a different name than devfile.yaml it can be referenced using a parameter devfilePath in the factory URL.

@benoitf benoitf added kind/enhancement A feature request - must adhere to the feature request template. engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. area/factory/dashboard Issues related to factories frontend (che user dashboard side) labels Oct 7, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Oct 7, 2021
@dmytro-ndp dmytro-ndp added severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Oct 7, 2021
@benoitf benoitf self-assigned this Oct 19, 2021
benoitf added a commit to eclipse-che/che-dashboard that referenced this issue Oct 19, 2021
benoitf added a commit to eclipse-che/che-dashboard that referenced this issue Oct 19, 2021
benoitf added a commit to eclipse-che/che-dashboard that referenced this issue Oct 19, 2021
@l0rd l0rd added new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes status/release-notes-review-needed Issues that needs to be reviewed by the doc team for the Release Notes wording labels Oct 19, 2021
@l0rd l0rd added this to the 7.38 milestone Oct 19, 2021
benoitf added a commit to eclipse-che/che-dashboard that referenced this issue Oct 19, 2021
benoitf added a commit to eclipse-che/che-dashboard that referenced this issue Oct 19, 2021
benoitf added a commit to eclipse-che/che-dashboard that referenced this issue Oct 19, 2021
@devstudio-release
Copy link

sync'd to Red Hat JIRA https://issues.redhat.com/browse/CRW-2396

@max-cx
Copy link

max-cx commented Nov 17, 2021

@benoitf, a Yes/No question to you:

Will the outcome require any changes to the relevant content of the Installation Guide or Administration Guide or End-user Guide?

Yes/No?

@max-cx
Copy link

max-cx commented Nov 17, 2021

@benoitf, I updated the Release Notes Text for this issue:


= Support for concurrent inclusion of devfiles v1 and v2

With this update, you can have both a devfile v1 and a devfile v2 in the same repository for loading your projects in a {prod-short} instance when using the DevWorkspace engine. You can also specify the path to your devfile v2 if your devfile v2 is not at the root of the repository or has a file name different from devfile.yaml.


Feel free to okay, comment, or correct it in https://issues.redhat.com/browse/CRW-2396.
Thanks!

@max-cx max-cx removed the status/release-notes-review-needed Issues that needs to be reviewed by the doc team for the Release Notes wording label Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/che-server area/factory/dashboard Issues related to factories frontend (che user dashboard side) engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/enhancement A feature request - must adhere to the feature request template. new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants