feat: Allow to override the path to the devfile from a given repository #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitf
requested review from
mshaposhnik,
nickboldt and
skabashnyuk
as code owners
|
✅ E2E Happy path tests succeed 🎉 See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
mshaposhnik
reviewed
Oct 16, 2021
...itbucket-server/src/main/java/org/eclipse/che/api/factory/server/bitbucket/BitbucketUrl.java
Show resolved
Hide resolved
mshaposhnik
reviewed
Oct 16, 2021
...re-api-factory-github/src/main/java/org/eclipse/che/api/factory/server/github/GithubUrl.java
Show resolved
Hide resolved
mshaposhnik
reviewed
Oct 16, 2021
...re-api-factory-gitlab/src/main/java/org/eclipse/che/api/factory/server/gitlab/GitlabUrl.java
Show resolved
Hide resolved
mshaposhnik
approved these changes
Oct 16, 2021
|
✅ E2E Happy path tests succeed 🎉 See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
skabashnyuk
approved these changes
Oct 18, 2021
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Che-server is looking for .devfile.yaml or devfile.yaml by default when specifying a Remote repository
But sometimes you may want to give a hint on the file you want to look inside the repository
usecase: let say I want to have both devfile v1 and v2 in the same repository, I need to provide the custom path to either devfile v1 or v2.
to the question: Why I don't provide the path to the devfile directly, it's because it's not matching the "repository" handling anymore (raw link vs context aware of the devfile)
Screenshot/screencast of this PR
What issues does this PR fix or reference?
eclipse-che/che#20607
How to test this PR?
Call the resolver API with an optional overide devfileName parameter
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.