Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow to specify the path to the devfile with factory workflow #385

Merged
merged 1 commit into from
Oct 19, 2021

Conversation

benoitf
Copy link
Contributor

@benoitf benoitf commented Oct 19, 2021

What does this PR do?

Allow to specify the name of the devfile to use in the repositories
so if there are .devfile.yaml (using v1) you can add a .devfile.v2 or .devfilev2.yaml in your repository and then specify the path to this file to load DevFile v2 workspaces

Appending ?devfilePath=devfilev2.yaml or ?df=devfilev2.yaml

What issues does this PR fix or reference?

Fixes eclipse-che/che#20607

Is it tested? How?

Tested using http://che-host/#https://github.com/benoitf/che-server?devfilePath=devfilev2.yaml

Also use short query df http://che-host/#https://github.com/benoitf/che-server?df=devfilev2.yaml

In that case it's fetching a totally different devfile than the default one (it's the one coming from spring petclinic) so at the end the workspace is named "spring-petclinic"
if you just provide http://che-host/#https://github.com/benoitf/che-server it's using the default name (and will fail on a devWorkspace enabled server)

Release Notes

Docs PR

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-385

1 similar comment
@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-385

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-385

@che-bot
Copy link
Contributor

che-bot commented Oct 19, 2021

✅ E2E dashboard tests succeed 🎉

See Details

Test product:

  • Use comment "[dashboard-ci-test]" to rerun the dashboard e2e tests

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

Copy link
Contributor

@akurinnoy akurinnoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Oct 19, 2021

Codecov Report

Merging #385 (6735b1b) into main (86893cd) will increase coverage by 0.00%.
The diff coverage is 54.54%.

❗ Current head 6735b1b differs from pull request most recent head bb9ff53. Consider uploading reports for the commit bb9ff53 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #385   +/-   ##
=======================================
  Coverage   48.74%   48.74%           
=======================================
  Files         193      193           
  Lines        6670     6677    +7     
  Branches     1081     1083    +2     
=======================================
+ Hits         3251     3255    +4     
- Misses       3105     3106    +1     
- Partials      314      316    +2     
Impacted Files Coverage Δ
...ashboard-frontend/src/services/helpers/location.ts 83.92% <54.54%> (-3.83%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86893cd...bb9ff53. Read the comment docs.

@openshift-ci
Copy link

openshift-ci bot commented Oct 19, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, benoitf, sleshchenko

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@benoitf
Copy link
Contributor Author

benoitf commented Oct 19, 2021

I'm not convinced about the parameter name so feel free to comment

Update: moving to devfilePath attribute name

@openshift-ci
Copy link

openshift-ci bot commented Oct 19, 2021

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the lgtm label Oct 19, 2021
@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-385

@che-bot
Copy link
Contributor

che-bot commented Oct 19, 2021

✅ E2E dashboard tests succeed 🎉

See Details

Test product:

  • Use comment "[dashboard-ci-test]" to rerun the dashboard e2e tests

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-385

@che-bot
Copy link
Contributor

che-bot commented Oct 19, 2021

✅ E2E dashboard tests succeed 🎉

See Details

Test product:

  • Use comment "[dashboard-ci-test]" to rerun the dashboard e2e tests

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@benoitf
Copy link
Contributor Author

benoitf commented Oct 19, 2021

/retest

@openshift-ci
Copy link

openshift-ci bot commented Oct 19, 2021

@benoitf: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v7-dashboard-happy-path f1fb6b9 link true /test v7-dashboard-happy-path

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@benoitf benoitf merged commit 9f40713 into main Oct 19, 2021
@benoitf benoitf deleted the CHE-20607 branch October 19, 2021 20:20
@che-bot che-bot added this to the 7.38 milestone Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to provide the path to the devfile yaml file when using factory workflow
4 participants