-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow to specify the path to the devfile with factory workflow #385
Conversation
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-385 |
1 similar comment
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-385 |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-385 |
✅ E2E dashboard tests succeed 🎉 See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## main #385 +/- ##
=======================================
Coverage 48.74% 48.74%
=======================================
Files 193 193
Lines 6670 6677 +7
Branches 1081 1083 +2
=======================================
+ Hits 3251 3255 +4
- Misses 3105 3106 +1
- Partials 314 316 +2
Continue to review full report at Codecov.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, benoitf, sleshchenko The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I'm not convinced about the parameter name so feel free to comment Update: moving to |
New changes are detected. LGTM label has been removed. |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-385 |
✅ E2E dashboard tests succeed 🎉 See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-385 |
✅ E2E dashboard tests succeed 🎉 See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
/retest |
@benoitf: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What does this PR do?
Allow to specify the name of the devfile to use in the repositories
so if there are .devfile.yaml (using v1) you can add a
.devfile.v2
or.devfilev2.yaml
in your repository and then specify the path to this file to load DevFile v2 workspacesAppending
?devfilePath=devfilev2.yaml
or?df=devfilev2.yaml
What issues does this PR fix or reference?
Fixes eclipse-che/che#20607
Is it tested? How?
Tested using
http://che-host/#https://github.com/benoitf/che-server?devfilePath=devfilev2.yaml
Also use short query
df
http://che-host/#https://github.com/benoitf/che-server?df=devfilev2.yaml
In that case it's fetching a totally different devfile than the default one (it's the one coming from spring petclinic) so at the end the workspace is named "spring-petclinic"
if you just provide
http://che-host/#https://github.com/benoitf/che-server
it's using the default name (and will fail on a devWorkspace enabled server)Release Notes
Docs PR