This repository has been archived by the owner on Jan 20, 2023. It is now read-only.
Use CWD(current working directory for tasks.) #21
+15
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
AndrienkoAleksandr
requested review from
azatsarynnyy,
mmorhun,
RomanNikitenko and
evidolob
RomanNikitenko
approved these changes
Mar 21, 2019
| @@ -43,13 +43,16 @@ export class CheTaskRunner implements TaskRunner { | |||
| throw new Error(`Che task config must have 'target.machineName' property specified`); | |||
| } | |||
|
|
|||
| const workingDir = taskConfig.target.workingDir; | |||
|
|
|||
There was a problem hiding this comment.
As I can see we don't use this const in another places, so you can just pass taskConfig.target.workingDir. But up to you.
azatsarynnyy
approved these changes
Mar 21, 2019
mmorhun
approved these changes
Mar 22, 2019
evidolob
suggested changes
Mar 22, 2019
|
Ok, I closed it, make sense this one: eclipse-che/che-theia#116 |
evidolob
approved these changes
Mar 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referenced issue:
eclipse-che/che#11866
Signed-off-by: Oleksandr Andriienko oandriie@redhat.com