This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Add cwd to the task plugin #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
AndrienkoAleksandr
requested review from
mmorhun,
evidolob,
akurinnoy and
azatsarynnyy
RomanNikitenko
approved these changes
Mar 21, 2019
| @@ -53,6 +53,10 @@ export class CheTaskProvider { | |||
| resultTarget.machineName = await this.machinePicker.pick(); | |||
| } | |||
|
|
|||
| if (target && target.workingDir) { | |||
| resultTarget.workingDir = cheTaskDefinition.target.workingDir; | |||
There was a problem hiding this comment.
You already have target here, so you can take workingDir from target directly, like resultTarget.workingDir = target.workingDir
| @@ -59,13 +59,16 @@ export class CheTaskRunner { | |||
| throw new Error("Che task config must have 'target.machineName' property specified"); | |||
| } | |||
|
|
|||
| const workingDir = target.workingDir; | |||
There was a problem hiding this comment.
Do we need this const here? As I can see we don't use it in another places, so you can just pass target.workingDir. But up to you.
There was a problem hiding this comment.
so many devs, so many minds
const cwd = target.workingDir;
...
tty: true,
cwd
};
azatsarynnyy
approved these changes
Mar 21, 2019
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
olexii4
approved these changes
Mar 21, 2019
mmorhun
approved these changes
Mar 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#116 (comment)
Signed-off-by: Oleksandr Andriienko oandriie@redhat.com