Update DEFAULT_CONFIG.json5 #1722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarify DEFAULT_CONFIG documentation in transport section
|
PR missing one of the required labels: {'internal', 'bug', 'new feature', 'dependencies', 'breaking-change', 'documentation', 'enhancement'} |
evshary
approved these changes
Jan 16, 2025
| accept_pending: 100, | ||
| /// Maximum number of sessions that can be simultaneously alive | ||
| /// Maximum number of transports that can be simultaneously alive for a single zenoh sessions |
There was a problem hiding this comment.
I thought it was the maximum number of sessions for a single transport based on the config name max_sessions. Is it possible for us to change the name? For example, max_per_session or something else.
There was a problem hiding this comment.
That would introduce a breaking change in the config I would rather avoid to introduce.
JEnoch
added a commit
to ZettaScaleLabs/rmw_zenoh
that referenced
this pull request
Feb 4, 2025
Yadunund
added a commit
to ros2/rmw_zenoh
that referenced
this pull request
Feb 4, 2025
* Bump: zenoh-cpp=bd4d741 zenoh-c=15d56e1 zenoh=e17de41 * Config: add new gossip target setting (eclipse-zenoh/zenoh#1678) * Config: add new interests timeout setting (eclipse-zenoh/zenoh#1710) * Config: copy updates from eclipse-zenoh/zenoh#1712 * Config: copy updates from eclipse-zenoh/zenoh#1722 * Config: copy updates from eclipse-zenoh/zenoh#1749 * Config: copy updates from eclipse-zenoh/zenoh#1751 * fix: use the commit 15d56e1 to include the allocation feature * Bump zenoh-c=5fce7fb zenoh=e4ea6f0 (for eclipse-zenoh/zenoh#1754 fixing a routing issue in 1.2.0) * Update documentation for commits and undo style changes Signed-off-by: Yadunund <yadunund@gmail.com> --------- Signed-off-by: Yadunund <yadunund@gmail.com> Co-authored-by: yuanyuyuan <az6980522@gmail.com> Co-authored-by: Yadunund <yadunund@gmail.com>
mergify bot
pushed a commit
to ros2/rmw_zenoh
that referenced
this pull request
Feb 4, 2025
* Bump: zenoh-cpp=bd4d741 zenoh-c=15d56e1 zenoh=e17de41 * Config: add new gossip target setting (eclipse-zenoh/zenoh#1678) * Config: add new interests timeout setting (eclipse-zenoh/zenoh#1710) * Config: copy updates from eclipse-zenoh/zenoh#1712 * Config: copy updates from eclipse-zenoh/zenoh#1722 * Config: copy updates from eclipse-zenoh/zenoh#1749 * Config: copy updates from eclipse-zenoh/zenoh#1751 * fix: use the commit 15d56e1 to include the allocation feature * Bump zenoh-c=5fce7fb zenoh=e4ea6f0 (for eclipse-zenoh/zenoh#1754 fixing a routing issue in 1.2.0) * Update documentation for commits and undo style changes Signed-off-by: Yadunund <yadunund@gmail.com> --------- Signed-off-by: Yadunund <yadunund@gmail.com> Co-authored-by: yuanyuyuan <az6980522@gmail.com> Co-authored-by: Yadunund <yadunund@gmail.com> (cherry picked from commit d322d6f)
mergify bot
pushed a commit
to ros2/rmw_zenoh
that referenced
this pull request
Feb 4, 2025
* Bump: zenoh-cpp=bd4d741 zenoh-c=15d56e1 zenoh=e17de41 * Config: add new gossip target setting (eclipse-zenoh/zenoh#1678) * Config: add new interests timeout setting (eclipse-zenoh/zenoh#1710) * Config: copy updates from eclipse-zenoh/zenoh#1712 * Config: copy updates from eclipse-zenoh/zenoh#1722 * Config: copy updates from eclipse-zenoh/zenoh#1749 * Config: copy updates from eclipse-zenoh/zenoh#1751 * fix: use the commit 15d56e1 to include the allocation feature * Bump zenoh-c=5fce7fb zenoh=e4ea6f0 (for eclipse-zenoh/zenoh#1754 fixing a routing issue in 1.2.0) * Update documentation for commits and undo style changes Signed-off-by: Yadunund <yadunund@gmail.com> --------- Signed-off-by: Yadunund <yadunund@gmail.com> Co-authored-by: yuanyuyuan <az6980522@gmail.com> Co-authored-by: Yadunund <yadunund@gmail.com> (cherry picked from commit d322d6f)
Yadunund
pushed a commit
to ros2/rmw_zenoh
that referenced
this pull request
Feb 4, 2025
* Bump: zenoh-cpp=bd4d741 zenoh-c=15d56e1 zenoh=e17de41 * Config: add new gossip target setting (eclipse-zenoh/zenoh#1678) * Config: add new interests timeout setting (eclipse-zenoh/zenoh#1710) * Config: copy updates from eclipse-zenoh/zenoh#1712 * Config: copy updates from eclipse-zenoh/zenoh#1722 * Config: copy updates from eclipse-zenoh/zenoh#1749 * Config: copy updates from eclipse-zenoh/zenoh#1751 * fix: use the commit 15d56e1 to include the allocation feature * Bump zenoh-c=5fce7fb zenoh=e4ea6f0 (for eclipse-zenoh/zenoh#1754 fixing a routing issue in 1.2.0) * Update documentation for commits and undo style changes Signed-off-by: Yadunund <yadunund@gmail.com> --------- Signed-off-by: Yadunund <yadunund@gmail.com> Co-authored-by: yuanyuyuan <az6980522@gmail.com> Co-authored-by: Yadunund <yadunund@gmail.com> (cherry picked from commit d322d6f) Co-authored-by: Julien Enoch <julien.e@zettascale.tech>
Yadunund
pushed a commit
to ros2/rmw_zenoh
that referenced
this pull request
Feb 4, 2025
* Bump: zenoh-cpp=bd4d741 zenoh-c=15d56e1 zenoh=e17de41 * Config: add new gossip target setting (eclipse-zenoh/zenoh#1678) * Config: add new interests timeout setting (eclipse-zenoh/zenoh#1710) * Config: copy updates from eclipse-zenoh/zenoh#1712 * Config: copy updates from eclipse-zenoh/zenoh#1722 * Config: copy updates from eclipse-zenoh/zenoh#1749 * Config: copy updates from eclipse-zenoh/zenoh#1751 * fix: use the commit 15d56e1 to include the allocation feature * Bump zenoh-c=5fce7fb zenoh=e4ea6f0 (for eclipse-zenoh/zenoh#1754 fixing a routing issue in 1.2.0) * Update documentation for commits and undo style changes Signed-off-by: Yadunund <yadunund@gmail.com> --------- Signed-off-by: Yadunund <yadunund@gmail.com> Co-authored-by: yuanyuyuan <az6980522@gmail.com> Co-authored-by: Yadunund <yadunund@gmail.com> (cherry picked from commit d322d6f) Co-authored-by: Julien Enoch <julien.e@zettascale.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify DEFAULT_CONFIG documentation in transport section