Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gossip_target configuration option #1678

Merged
merged 7 commits into from
Jan 7, 2025
Merged

Conversation

OlivierHecart
Copy link
Contributor

Add gossip_target configuration option.

This options allows to restrain the type of zenoh instances (router, peer) the configured instance sends gossip messages to.
This may typically be used in rmw_zenoh to make peers do gossip with the router but not between each other saving a lot of traffic and computation.

@OlivierHecart OlivierHecart added enhancement Existing things could work better new feature Something new is needed labels Dec 19, 2024
Copy link
Member

@fuzzypixelz fuzzypixelz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this with 1 router and 10 peers.

With scouting/gossip/target:["router"] on the peers:

$ tshark -r out.pcap -d tcp.port==60000-70000,zenoh -Y 'tcp.port != 7447' | grep -c 'OAM'
0

Without scouting/gossip/target:["router"] on the peers (i.e. the ["router", "peer"] default):

$ tshark -r out.pcap -d tcp.port==60000-70000,zenoh -Y 'tcp.port != 7447' | grep -c 'OAM'
139

Copy link
Contributor

@oteffahi oteffahi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments regarding default config

DEFAULT_CONFIG.json5 Show resolved Hide resolved
DEFAULT_CONFIG.json5 Show resolved Hide resolved
@OlivierHecart OlivierHecart enabled auto-merge (squash) January 7, 2025 16:31
@OlivierHecart OlivierHecart merged commit e9298c6 into main Jan 7, 2025
25 checks passed
@OlivierHecart OlivierHecart deleted the dev/gossip_target branch January 7, 2025 16:39
JEnoch added a commit to ZettaScaleLabs/rmw_zenoh that referenced this pull request Feb 4, 2025
Yadunund added a commit to ros2/rmw_zenoh that referenced this pull request Feb 4, 2025
* Bump: zenoh-cpp=bd4d741 zenoh-c=15d56e1 zenoh=e17de41

* Config: add new gossip target setting (eclipse-zenoh/zenoh#1678)

* Config: add new interests timeout setting (eclipse-zenoh/zenoh#1710)

* Config: copy updates from eclipse-zenoh/zenoh#1712

* Config: copy updates from eclipse-zenoh/zenoh#1722

* Config: copy updates from eclipse-zenoh/zenoh#1749

* Config: copy updates from eclipse-zenoh/zenoh#1751

* fix: use the commit 15d56e1 to include the allocation feature

* Bump zenoh-c=5fce7fb zenoh=e4ea6f0 (for eclipse-zenoh/zenoh#1754 fixing a routing issue in 1.2.0)

* Update documentation for commits and undo style changes

Signed-off-by: Yadunund <yadunund@gmail.com>

---------

Signed-off-by: Yadunund <yadunund@gmail.com>
Co-authored-by: yuanyuyuan <az6980522@gmail.com>
Co-authored-by: Yadunund <yadunund@gmail.com>
mergify bot pushed a commit to ros2/rmw_zenoh that referenced this pull request Feb 4, 2025
* Bump: zenoh-cpp=bd4d741 zenoh-c=15d56e1 zenoh=e17de41

* Config: add new gossip target setting (eclipse-zenoh/zenoh#1678)

* Config: add new interests timeout setting (eclipse-zenoh/zenoh#1710)

* Config: copy updates from eclipse-zenoh/zenoh#1712

* Config: copy updates from eclipse-zenoh/zenoh#1722

* Config: copy updates from eclipse-zenoh/zenoh#1749

* Config: copy updates from eclipse-zenoh/zenoh#1751

* fix: use the commit 15d56e1 to include the allocation feature

* Bump zenoh-c=5fce7fb zenoh=e4ea6f0 (for eclipse-zenoh/zenoh#1754 fixing a routing issue in 1.2.0)

* Update documentation for commits and undo style changes

Signed-off-by: Yadunund <yadunund@gmail.com>

---------

Signed-off-by: Yadunund <yadunund@gmail.com>
Co-authored-by: yuanyuyuan <az6980522@gmail.com>
Co-authored-by: Yadunund <yadunund@gmail.com>
(cherry picked from commit d322d6f)
mergify bot pushed a commit to ros2/rmw_zenoh that referenced this pull request Feb 4, 2025
* Bump: zenoh-cpp=bd4d741 zenoh-c=15d56e1 zenoh=e17de41

* Config: add new gossip target setting (eclipse-zenoh/zenoh#1678)

* Config: add new interests timeout setting (eclipse-zenoh/zenoh#1710)

* Config: copy updates from eclipse-zenoh/zenoh#1712

* Config: copy updates from eclipse-zenoh/zenoh#1722

* Config: copy updates from eclipse-zenoh/zenoh#1749

* Config: copy updates from eclipse-zenoh/zenoh#1751

* fix: use the commit 15d56e1 to include the allocation feature

* Bump zenoh-c=5fce7fb zenoh=e4ea6f0 (for eclipse-zenoh/zenoh#1754 fixing a routing issue in 1.2.0)

* Update documentation for commits and undo style changes

Signed-off-by: Yadunund <yadunund@gmail.com>

---------

Signed-off-by: Yadunund <yadunund@gmail.com>
Co-authored-by: yuanyuyuan <az6980522@gmail.com>
Co-authored-by: Yadunund <yadunund@gmail.com>
(cherry picked from commit d322d6f)
Yadunund pushed a commit to ros2/rmw_zenoh that referenced this pull request Feb 4, 2025
* Bump: zenoh-cpp=bd4d741 zenoh-c=15d56e1 zenoh=e17de41

* Config: add new gossip target setting (eclipse-zenoh/zenoh#1678)

* Config: add new interests timeout setting (eclipse-zenoh/zenoh#1710)

* Config: copy updates from eclipse-zenoh/zenoh#1712

* Config: copy updates from eclipse-zenoh/zenoh#1722

* Config: copy updates from eclipse-zenoh/zenoh#1749

* Config: copy updates from eclipse-zenoh/zenoh#1751

* fix: use the commit 15d56e1 to include the allocation feature

* Bump zenoh-c=5fce7fb zenoh=e4ea6f0 (for eclipse-zenoh/zenoh#1754 fixing a routing issue in 1.2.0)

* Update documentation for commits and undo style changes

Signed-off-by: Yadunund <yadunund@gmail.com>

---------

Signed-off-by: Yadunund <yadunund@gmail.com>
Co-authored-by: yuanyuyuan <az6980522@gmail.com>
Co-authored-by: Yadunund <yadunund@gmail.com>
(cherry picked from commit d322d6f)

Co-authored-by: Julien Enoch <julien.e@zettascale.tech>
Yadunund pushed a commit to ros2/rmw_zenoh that referenced this pull request Feb 4, 2025
* Bump: zenoh-cpp=bd4d741 zenoh-c=15d56e1 zenoh=e17de41

* Config: add new gossip target setting (eclipse-zenoh/zenoh#1678)

* Config: add new interests timeout setting (eclipse-zenoh/zenoh#1710)

* Config: copy updates from eclipse-zenoh/zenoh#1712

* Config: copy updates from eclipse-zenoh/zenoh#1722

* Config: copy updates from eclipse-zenoh/zenoh#1749

* Config: copy updates from eclipse-zenoh/zenoh#1751

* fix: use the commit 15d56e1 to include the allocation feature

* Bump zenoh-c=5fce7fb zenoh=e4ea6f0 (for eclipse-zenoh/zenoh#1754 fixing a routing issue in 1.2.0)

* Update documentation for commits and undo style changes

Signed-off-by: Yadunund <yadunund@gmail.com>

---------

Signed-off-by: Yadunund <yadunund@gmail.com>
Co-authored-by: yuanyuyuan <az6980522@gmail.com>
Co-authored-by: Yadunund <yadunund@gmail.com>
(cherry picked from commit d322d6f)

Co-authored-by: Julien Enoch <julien.e@zettascale.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Existing things could work better new feature Something new is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants