Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wallet shown as not connect in Portal frontend due to wrongly named credentialType #216

Closed
evegufy opened this issue Jul 25, 2024 · 1 comment
Closed

Wallet shown as not connect in Portal frontend due to wrongly named credentialType #216

evegufy opened this issue Jul 25, 2024 · 1 comment
Assignees
@Phil91 @evegufy
Labels
bug Something isn't working
Milestone
Release 1.1.0 (24...

Comments

@evegufy
Copy link
Contributor

evegufy commented Jul 25, 2024

Current Behavior

Portal Frontend expects credentialType MEMBERSHIP from GET endpoint /api/issuer/owned-credentials (see eclipse-tractusx/portal-frontend#621) to show wallet as connected but it's currently named MEMBERSHIP_CERTIFICATE, which leads to:
image

Expected Behavior

credentialType is named MEMBERSHIP

Steps To Reproduce

Detected in v1.1.0-rc.1

follow up to #175
@evegufy evegufy added the bug Something isn't working label Jul 25, 2024
@evegufy evegufy added this to Portal Jul 25, 2024
@github-project-automation github-project-automation bot moved this to NEW USER REQUEST in Portal Jul 25, 2024
@evegufy evegufy added this to the Release 1.1.0 (24.08) milestone Jul 25, 2024
@evegufy evegufy moved this from NEW USER REQUEST to BACKLOG in Portal Jul 25, 2024
@Phil91 Phil91 moved this from BACKLOG to IN PROGRESS in Portal Jul 25, 2024
Phil91 added a commit that referenced this issue Jul 25, 2024
@Phil91
fix(credentialType): rename membership certificate to membership
3fb33c6 
Refs: #216
@Phil91 Phil91 mentioned this issue Jul 25, 2024
Merged
9 tasks
Phil91 added a commit that referenced this issue Jul 25, 2024
@Phil91
fix(credentialType): rename membership certificate to membership (#217)
818a9a3 
Refs: #216
Reviewed-By: Evelyn Gurschler <evelyn.gurschler@bmw.de>
@github-actions github-actions bot mentioned this issue Jul 25, 2024
Merged
@evegufy
Copy link
Contributor Author

evegufy commented Jul 25, 2024

tested successfully

@evegufy evegufy closed this as completed Jul 25, 2024
@github-project-automation github-project-automation bot moved this from IN PROGRESS to USER READY in Portal Jul 25, 2024
@evegufy evegufy self-assigned this Jul 25, 2024
@github-actions github-actions bot mentioned this issue Oct 10, 2024
Closed
@github-actions github-actions bot mentioned this issue Oct 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Phil91 Phil91

@evegufy evegufy

Labels
bug Something isn't working
Projects
Portal
Archived in project
Milestone
Release 1.1.0 (24.08)
Development

No branches or pull requests
2 participants
@Phil91 @evegufy