fix(credentialType): rename membership certificate to membership (#217)

Refs: #216 Reviewed-By: Evelyn Gurschler <evelyn.gurschler@bmw.de>
eclipse-tractusx · Jul 25, 2024 · 818a9a3 · 818a9a3
1 parent 4ca94c5
commit 818a9a3
Show file tree

Hide file tree

Showing 17 changed files with 1,765 additions and 66 deletions.
diff --git a/src/credentials/SsiCredentialIssuer.Expiry.App/ExpiryCheckService.cs b/src/credentials/SsiCredentialIssuer.Expiry.App/ExpiryCheckService.cs
@@ -168,7 +168,7 @@ private static async ValueTask HandleNotification(
 
         var content = JsonSerializer.Serialize(new
         {
-            Type = data.VerifiedCredentialTypeId,
+            Type = data.VerifiedCredentialExternalTypeId,
             ExpiryDate = data.ExpiryDate?.ToString("O") ?? throw new ConflictException("Expiry Date must be set here"),
             Version = data.DetailVersion,
             CredentialId = data.Id,
@@ -179,9 +179,9 @@ private static async ValueTask HandleNotification(
         {
             await portalService.AddNotification(content, requesterId, NotificationTypeId.CREDENTIAL_EXPIRY,
                 cancellationToken).ConfigureAwait(ConfigureAwaitOptions.None);
-            var typeValue = data.VerifiedCredentialTypeId.GetEnumValue() ??
+            var typeValue = data.VerifiedCredentialExternalTypeId.GetEnumValue() ??
                             throw new UnexpectedConditionException(
-                                $"VerifiedCredentialType {data.VerifiedCredentialTypeId} does not exists");
+                                $"VerifiedCredentialType {data.VerifiedCredentialExternalTypeId} does not exists");
             var mailParameters = new MailParameter[]
             {
                 new("typeId", typeValue), new("version", data.DetailVersion ?? "no version"),

diff --git a/src/database/SsiCredentialIssuer.DbAccess/Models/CredentialExpiryData.cs b/src/database/SsiCredentialIssuer.DbAccess/Models/CredentialExpiryData.cs
@@ -29,7 +29,7 @@ public record CredentialExpiryData(
     string? DetailVersion,
     string Bpnl,
     CompanySsiDetailStatusId CompanySsiDetailStatusId,
-    VerifiedCredentialTypeId VerifiedCredentialTypeId,
+    VerifiedCredentialExternalTypeId VerifiedCredentialExternalTypeId,
     CredentialScheduleData ScheduleData);
 
 public record CredentialScheduleData(

diff --git a/src/database/SsiCredentialIssuer.DbAccess/Models/SsiApprovalData.cs b/src/database/SsiCredentialIssuer.DbAccess/Models/SsiApprovalData.cs
@@ -24,7 +24,7 @@ namespace Org.Eclipse.TractusX.SsiCredentialIssuer.DBAccess.Models;
 
 public record SsiApprovalData(
     CompanySsiDetailStatusId Status,
-    VerifiedCredentialTypeId Type,
+    VerifiedCredentialExternalTypeId Type,
     Guid? ProcessId,
     VerifiedCredentialTypeKindId? Kind,
     string Bpn,

diff --git a/src/database/SsiCredentialIssuer.DbAccess/Repositories/CompanySsiDetailsRepository.cs b/src/database/SsiCredentialIssuer.DbAccess/Repositories/CompanySsiDetailsRepository.cs
@@ -186,7 +186,7 @@ public IAsyncEnumerable<OwnedVerifiedCredentialData> GetOwnCredentialDetails(str
                 true,
                 new SsiApprovalData(
                     x.CompanySsiDetailStatusId,
-                    x.VerifiedCredentialTypeId,
+                    x.VerifiedCredentialType!.VerifiedCredentialTypeAssignedExternalType!.VerifiedCredentialExternalTypeId,
                     x.ProcessId,
                     x.VerifiedCredentialType!.VerifiedCredentialTypeAssignedKind == null ? null : x.VerifiedCredentialType!.VerifiedCredentialTypeAssignedKind!.VerifiedCredentialTypeKindId,
                     x.Bpnl,
@@ -205,13 +205,13 @@ public IAsyncEnumerable<OwnedVerifiedCredentialData> GetOwnCredentialDetails(str
             .SingleOrDefaultAsync();
 
     /// <inheritdoc />
-    public Task<(bool Exists, CompanySsiDetailStatusId Status, VerifiedCredentialTypeId Type, string UserId, Guid? ProcessId, IEnumerable<Guid> ProcessStepIds)> GetSsiRejectionData(Guid credentialId) =>
+    public Task<(bool Exists, CompanySsiDetailStatusId Status, VerifiedCredentialExternalTypeId Type, string UserId, Guid? ProcessId, IEnumerable<Guid> ProcessStepIds)> GetSsiRejectionData(Guid credentialId) =>
         context.CompanySsiDetails
             .Where(x => x.Id == credentialId)
-            .Select(x => new ValueTuple<bool, CompanySsiDetailStatusId, VerifiedCredentialTypeId, string, Guid?, IEnumerable<Guid>>(
+            .Select(x => new ValueTuple<bool, CompanySsiDetailStatusId, VerifiedCredentialExternalTypeId, string, Guid?, IEnumerable<Guid>>(
                 true,
                 x.CompanySsiDetailStatusId,
-                x.VerifiedCredentialTypeId,
+                x.VerifiedCredentialType!.VerifiedCredentialTypeAssignedExternalType!.VerifiedCredentialExternalTypeId,
                 x.CreatorUserId,
                 x.ProcessId,
                 x.Process!.ProcessSteps.Where(ps => ps.ProcessStepStatusId == ProcessStepStatusId.TODO).Select(p => p.Id)
@@ -263,7 +263,7 @@ public IAsyncEnumerable<CredentialExpiryData> GetExpiryData(DateTimeOffset now,
                 x.Details.VerifiedCredentialExternalTypeDetailVersion!.Version,
                 x.Details.Bpnl,
                 x.Details.CompanySsiDetailStatusId,
-                x.Details.VerifiedCredentialTypeId,
+                x.Details.VerifiedCredentialType!.VerifiedCredentialTypeAssignedExternalType!.VerifiedCredentialExternalTypeId,
                 new CredentialScheduleData(
                     x.IsVcToDelete,
                     x.IsOneDayNotification,

diff --git a/src/database/SsiCredentialIssuer.DbAccess/Repositories/CredentialRepository.cs b/src/database/SsiCredentialIssuer.DbAccess/Repositories/CredentialRepository.cs
@@ -91,10 +91,10 @@ public void AttachAndModifyCredential(Guid credentialId, Action<CompanySsiDetail
         modify(entity);
     }
 
-    public Task<(VerifiedCredentialTypeId TypeId, string RequesterId)> GetCredentialNotificationData(Guid credentialId) =>
+    public Task<(VerifiedCredentialExternalTypeId ExternalTypeId, string RequesterId)> GetCredentialNotificationData(Guid credentialId) =>
         dbContext.CompanySsiDetails
             .Where(x => x.Id == credentialId)
-            .Select(x => new ValueTuple<VerifiedCredentialTypeId, string>(x.VerifiedCredentialTypeId, x.CreatorUserId))
+            .Select(x => new ValueTuple<VerifiedCredentialExternalTypeId, string>(x.VerifiedCredentialType!.VerifiedCredentialTypeAssignedExternalType!.VerifiedCredentialExternalTypeId, x.CreatorUserId))
             .SingleOrDefaultAsync();
 
     public Task<(bool Exists, bool IsSameCompany, IEnumerable<(DocumentStatusId StatusId, byte[] Content)> Documents)> GetSignedCredentialForCredentialId(Guid credentialId, string bpnl) =>

diff --git a/src/database/SsiCredentialIssuer.DbAccess/Repositories/ICompanySsiDetailsRepository.cs b/src/database/SsiCredentialIssuer.DbAccess/Repositories/ICompanySsiDetailsRepository.cs
@@ -96,7 +96,7 @@ public interface ICompanySsiDetailsRepository
     IAsyncEnumerable<OwnedVerifiedCredentialData> GetOwnCredentialDetails(string bpnl);
 
     Task<(bool exists, SsiApprovalData data)> GetSsiApprovalData(Guid credentialId);
-    Task<(bool Exists, CompanySsiDetailStatusId Status, VerifiedCredentialTypeId Type, string UserId, Guid? ProcessId, IEnumerable<Guid> ProcessStepIds)> GetSsiRejectionData(Guid credentialId);
+    Task<(bool Exists, CompanySsiDetailStatusId Status, VerifiedCredentialExternalTypeId Type, string UserId, Guid? ProcessId, IEnumerable<Guid> ProcessStepIds)> GetSsiRejectionData(Guid credentialId);
     void AttachAndModifyCompanySsiDetails(Guid id, Action<CompanySsiDetail>? initialize, Action<CompanySsiDetail> updateFields);
     IAsyncEnumerable<VerifiedCredentialTypeId> GetCertificateTypes(string bpnl);
     IAsyncEnumerable<CredentialExpiryData> GetExpiryData(DateTimeOffset now, DateTimeOffset inactiveVcsToDelete, DateTimeOffset expiredVcsToDelete);

diff --git a/src/database/SsiCredentialIssuer.DbAccess/Repositories/ICredentialRepository.cs b/src/database/SsiCredentialIssuer.DbAccess/Repositories/ICredentialRepository.cs
@@ -34,7 +34,7 @@ public interface ICredentialRepository
     Task<(string Bpn, string? CallbackUrl)> GetCallbackUrl(Guid credentialId);
     Task<(bool Exists, bool IsSameBpnl, Guid? ExternalCredentialId, CompanySsiDetailStatusId StatusId, IEnumerable<(Guid DocumentId, DocumentStatusId DocumentStatusId)> Documents)> GetRevocationDataById(Guid credentialId, string bpnl);
     void AttachAndModifyCredential(Guid credentialId, Action<CompanySsiDetail>? initialize, Action<CompanySsiDetail> modify);
-    Task<(VerifiedCredentialTypeId TypeId, string RequesterId)> GetCredentialNotificationData(Guid credentialId);
+    Task<(VerifiedCredentialExternalTypeId ExternalTypeId, string RequesterId)> GetCredentialNotificationData(Guid credentialId);
     Task<(bool Exists, bool IsSameCompany, IEnumerable<(DocumentStatusId StatusId, byte[] Content)> Documents)> GetSignedCredentialForCredentialId(Guid credentialId, string bpnl);
     Task<(bool Exists, bool IsSameCompany, string FileName, DocumentStatusId StatusId, byte[] Content, MediaTypeId MediaTypeId)> GetDocumentById(Guid documentId, string bpnl);
 }
diff --git a/src/database/SsiCredentialIssuer.Entities/Enums/VerifiedCredentialTypeId.cs b/src/database/SsiCredentialIssuer.Entities/Enums/VerifiedCredentialTypeId.cs
@@ -17,45 +17,31 @@
  * SPDX-License-Identifier: Apache-2.0
  ********************************************************************************/
 
-using System.Runtime.Serialization;
-
 namespace Org.Eclipse.TractusX.SsiCredentialIssuer.Entities.Enums;
 
 public enum VerifiedCredentialTypeId
 {
-    [EnumMember(Value = "Traceability Framework")]
     TRACEABILITY_FRAMEWORK = 1,
 
-    [EnumMember(Value = "PCF Framework")]
     PCF_FRAMEWORK = 2,
 
-    [EnumMember(Value = "Behavior Twin Framework")]
     BEHAVIOR_TWIN_FRAMEWORK = 3,
 
-    [EnumMember(Value = "Membership Certificate")]
-    MEMBERSHIP_CERTIFICATE = 4,
+    MEMBERSHIP = 4,
 
-    [EnumMember(Value = "Circular Economy")]
     CIRCULAR_ECONOMY = 5,
 
-    [EnumMember(Value = "frameworkAgreement.quality")]
     FRAMEWORK_AGREEMENT_QUALITY = 6,
 
-    [EnumMember(Value = "BusinessPartnerCredential")]
     BUSINESS_PARTNER_NUMBER = 7,
 
-    [EnumMember(Value = "Demand and Capacity Management")]
     DEMAND_AND_CAPACITY_MANAGEMENT = 8,
 
-    [EnumMember(Value = "Demand and Capacity Management")]
     DEMAND_AND_CAPACITY_MANAGEMENT_PURIS = 9,
 
-    [EnumMember(Value = "Business Partner Data Management")]
     BUSINESS_PARTNER_DATA_MANAGEMENT = 10,
 
-    [EnumMember(Value = "Framework Agreement")]
     FRAMEWORK_AGREEMENT = 11,
 
-    [EnumMember(Value = "Date Exchange Governance")]
     DATA_EXCHANGE_GOVERNANCE_CREDENTIAL = 12
 }