refactor(src-components): rename files to common naming style #1351
Conversation
…into feat/1238/rename-files-in-src-components
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/components/pages/Admin/RegistrationRequests/ConfirmationOverlay/ConfirmCancelOverlay.tsx
Fixed
Show fixed
Hide fixed
src/components/pages/Admin/RegistrationRequests/ConfirmationOverlay/ConfirmCancelOverlay.tsx
Fixed
Show fixed
Hide fixed
…into feat/1238/rename-files-in-src-components
There was a problem hiding this comment.
@lavanya-bmw please resolve conflict
@manojava-gk @kunalgaurav-bmw please review
| @@ -96,14 +96,14 @@ const ConfirmaCancelOverlay = ({ | |||
| <DialogHeader | |||
| title={t( | |||
| 'content.admin.registration-requests.confirmCancelModal.title' | |||
| ).replace('{companyName}', companyName ? companyName : '')} | |||
| ).replace('{companyName}', companyName)} | |||
There was a problem hiding this comment.
I believe the condition is to prevent crash issue. Kindly reverify once
There was a problem hiding this comment.
In line 86, we are checking for companyName availability, so the condition here is not required
| /> | ||
| <DialogContent> | ||
| <div style={{ textAlign: 'center' }}> | ||
| <Typography variant="body1"> | ||
| {t( | ||
| 'content.admin.registration-requests.confirmCancelModal.description' | ||
| ).replace('{companyName}', companyName ? companyName : '')} | ||
| ).replace('{companyName}', companyName)} |
There was a problem hiding this comment.
I believe the condition is to prevent crash issue. Kindly reverify once
There was a problem hiding this comment.
In line 86, we are checking for companyName availability, so the condition here is not required
| @@ -228,7 +229,7 @@ export const RegistrationRequestsTableColumns = ( | |||
| </span> | |||
| {row.applicationStatus === ApplicationRequestStatus.SUBMITTED && | |||
| !row.bpn && ( | |||
| <span | |||
| <Box | |||
There was a problem hiding this comment.
this pattern looks weird.
<div>
<span></span>
<Box></Box>
</div>
Pls refactor this container
| import type { AppDetails } from 'features/apps/types' | ||
| import { PrivacyPolicyType } from 'features/adminBoard/adminBoardApiSlice' | ||
| import '../../AppDetail.scss' | ||
| import '../style.scss' |
There was a problem hiding this comment.
better to use only ./style.scss.
move css to respective file and remove the import statement
| import './AppDetailTags.scss' | ||
| import '../../AppDetail.scss' | ||
| import './style.scss' | ||
| import '../style.scss' |
There was a problem hiding this comment.
better to use only ./style.scss.
move css to respective file and remove the import statement
|
@lavanya-bmw sonarcloud flagged 3 issues can you check them once. |
I will check with @oyo regarding these issues as I think they are not valid issues |
…into feat/1238/rename-files-in-src-components
…into feat/1238/rename-files-in-src-components
|
@isaadansari could you please review as well? |
evegufy
changed the title
…into feat/1238/rename-files-in-src-components
…into feat/1238/rename-files-in-src-components
|
|
@evegufy sorry I missed your message, |
|
@lavanya-bmw if you are cleaning up the codebase, I have a few suggestions,
|
|
Hi @saadanzari great that you think of such suggestions. Could you please create issues of those suggestions? A comment on an already merged pull request won't get implemented. |
|
thanks for the feedback @evegufy I have created separate enhancement tickets for them. |
Description
Renamed files in src/components folder to common naming style
Changelog:
Why
All files in src/components should follow one naming style
Issue
#1238
Checklist
Please delete options that are not relevant.