feat(locales): update translations files #1421
Conversation
|
| @@ -479,7 +481,6 @@ | |||
| "message": "The Privacy Policy states which data the business applications collects, handles and processes. The details below explicitly show which company / user information are getting collected/stored.", | |||
| "notSupportedMessage": "Currently not yet supported", | |||
| "COMPANY_DATA": "Company Data", | |||
| "COMPANY_DATA_ICON": "ApartmentIcon", | |||
| "USER_DATA": "User Data", | |||
There was a problem hiding this comment.
Some wrong practice has been introduced here. I know this is not part of the PR. Could you check as it is a small fix?
There was a problem hiding this comment.
@charmi-v guideline says to use camelCase here
There was a problem hiding this comment.
Thank you for highlighting this, @manojava-gk. The issue arose during the implementation of the new design for the company subscription details page. I referenced the same file (locales/en/main.json), utilizing existing key usages such as REGISTRATION_VERIFICATION and IN_PROGRESS to validate it directly as an enum.
Currently, COMPANY_DATA_ICON is accurately mapping icons based on the enum key check.
I will review and consider refactoring this in alignment with the suggested guidelines shortly.
Description
Unused translations for locales files are removed and missing translations are added.
Changelog:
Why
Unused translations for locales files to be removed and missing translations to be added
Issue
#1419
Checklist
Please delete options that are not relevant.