-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(services service): adjust error handling #1195
feat(services service): adjust error handling #1195
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would make sense to include the offers.library project and offers.library.web as well since those are accessed as well from the services.service
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AnuragNagpure : This PR implements the respective exceptions that are thrown by ServiceBusinessLogic and ServiceReleaseBusinessLogic. Exceptions that is thrown by the delegate-classes (e.g. OfferService, OfferSubscriptionService, OfferSetupService) also need to be implemented. As this is independent from this PR I'm merging this one. Please create a new PR for the implementation of the respective ErrorTypes.
( FYI: @Phil91 )
respective errortypes/codes shall be implemented in a new PR. I left a comment requesting this in the ticket.
Sure Will do that |
Description
Implement new error handling in below mentioned Services Service Controller and respective Business Logic
ServiceChangeController
ServiceReleaseController
ServicesController
All supported exceptions need to get transferred to the new error response method.
Why
Implement for all controller and its business logic the new error handling - see details regarding the structure below.
{
"type": "string",
"title": "string",
"status": 0,
"errors": {
"additionalProp1": [
"string"
],
"additionalProp2": [
"string"
],
"additionalProp3": [
"string"
]
},
"errorId": "string",
"details": [
{
"errorCode": "string",
"type": "string",
"message": "string",
"parameters": [
{
"name": "string",
"value": "string"
}
]
}
]
}
Issue
#1185
Checklist
Please delete options that are not relevant.