Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(services service): adjust error handling #1195

Conversation

AnuragNagpure
Copy link
Contributor

Description

Implement new error handling in below mentioned Services Service Controller and respective Business Logic

ServiceChangeController
ServiceReleaseController
ServicesController

All supported exceptions need to get transferred to the new error response method.

Why

Implement for all controller and its business logic the new error handling - see details regarding the structure below.

{
"type": "string",
"title": "string",
"status": 0,
"errors": {
"additionalProp1": [
"string"
],
"additionalProp2": [
"string"
],
"additionalProp3": [
"string"
]
},
"errorId": "string",
"details": [
{
"errorCode": "string",
"type": "string",
"message": "string",
"parameters": [
{
"name": "string",
"value": "string"
}
]
}
]
}

Issue

#1185

Checklist

Please delete options that are not relevant.

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@AnuragNagpure AnuragNagpure requested review from Phil91, typecastcloud and ntruchsess and removed request for typecastcloud December 3, 2024 03:47
@AnuragNagpure AnuragNagpure added this to the Release 25.03 milestone Dec 3, 2024
Phil91
Phil91 previously requested changes Dec 3, 2024
Copy link
Member

@Phil91 Phil91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would make sense to include the offers.library project and offers.library.web as well since those are accessed as well from the services.service

@Phil91 Phil91 self-assigned this Dec 9, 2024
@evegufy evegufy changed the title feat(error): error handling adjusted in services service feat(services service): adjust error handling Dec 13, 2024
Copy link
Contributor

@ntruchsess ntruchsess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AnuragNagpure : This PR implements the respective exceptions that are thrown by ServiceBusinessLogic and ServiceReleaseBusinessLogic. Exceptions that is thrown by the delegate-classes (e.g. OfferService, OfferSubscriptionService, OfferSetupService) also need to be implemented. As this is independent from this PR I'm merging this one. Please create a new PR for the implementation of the respective ErrorTypes.
( FYI: @Phil91 )

@ntruchsess ntruchsess dismissed Phil91’s stale review December 17, 2024 15:50

respective errortypes/codes shall be implemented in a new PR. I left a comment requesting this in the ticket.

@ntruchsess ntruchsess merged commit 07895a0 into eclipse-tractusx:main Dec 17, 2024
11 checks passed
@AnuragNagpure
Copy link
Contributor Author

@AnuragNagpure : This PR implements the respective exceptions that are thrown by ServiceBusinessLogic and ServiceReleaseBusinessLogic. Exceptions that is thrown by the delegate-classes (e.g. OfferService, OfferSubscriptionService, OfferSetupService) also need to be implemented. As this is independent from this PR I'm merging this one. Please create a new PR for the implementation of the respective ErrorTypes. ( FYI: @Phil91 )

Sure Will do that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: USER READY
Development

Successfully merging this pull request may close these issues.

3 participants