Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handling in Services Service #1185

Open
AnuragNagpure opened this issue Nov 26, 2024 · 2 comments
Open

Error handling in Services Service #1185

AnuragNagpure opened this issue Nov 26, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@AnuragNagpure
Copy link
Contributor

Description

Implement new error handling in below mentioned Services Service Controller and respective Business Logic

ServiceChangeController
ServiceReleaseController
ServicesController

All supported exceptions need to get transferred to the new error response method.

Acceptance Criteria

Implement for all controller and its business logic the new error handling - see details regarding the structure below.

{
"type": "string",
"title": "string",
"status": 0,
"errors": {
"additionalProp1": [
"string"
],
"additionalProp2": [
"string"
],
"additionalProp3": [
"string"
]
},
"errorId": "string",
"details": [
{
"errorCode": "string",
"type": "string",
"message": "string",
"parameters": [
{
"name": "string",
"value": "string"
}
]
}
]
}

Additional Information

Please refer the new implementation structure in Administrative >> ErrorHandling >> AdministrationRegistrationErrorMessageContainer.cs

@AnuragNagpure AnuragNagpure added the enhancement New feature or request label Nov 26, 2024
@github-project-automation github-project-automation bot moved this to NEW USER REQUEST in Portal Nov 26, 2024
@AnuragNagpure AnuragNagpure self-assigned this Dec 3, 2024
@AnuragNagpure AnuragNagpure moved this from NEW USER REQUEST to IN PROGRESS in Portal Dec 3, 2024
@Phil91 Phil91 added this to the Release 25.03 milestone Dec 3, 2024
@ntruchsess
Copy link
Contributor

PR #1195 implements the respective exceptions that are thrown by ServiceBusinessLogic and ServiceReleaseBusinessLogic. Exceptions that is thrown by the delegate-classes (e.g. OfferService, OfferSubscriptionService, OfferSetupService) also need to be implemented. Please create a new PR for that.

@AnuragNagpure
Copy link
Contributor Author

PR #1195 implements the respective exceptions that are thrown by ServiceBusinessLogic and ServiceReleaseBusinessLogic. Exceptions that is thrown by the delegate-classes (e.g. OfferService, OfferSubscriptionService, OfferSetupService) also need to be implemented. Please create a new PR for that.

Sure will do that By creating seperate ticket

@AnuragNagpure AnuragNagpure moved this from IN PROGRESS to IN REVIEW in Portal Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: IN REVIEW
Development

No branches or pull requests

3 participants