-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add AAS AID tooling #7
feat: add AAS AID tooling #7
Conversation
We had a quick look and I think we should not have the eslint and prettier in each tool folder. There are root configs available and seem similar. |
Makes sense. I didn't even look at the root level. Anyhow, I noticed some shortcoming w.r.t. to the current setup.
Hence, I opened a dedicated issue for it (see #8)
|
asset-interface-description.ts --> asset-interfaces-description.ts AssetInterfaceDescriptionTest --> asset-interfaces-description-test.ts
We have discussed in the call:
|
* transformAID2TD(...) * transformTD2AID(...)
The PR is now ready for review. As discussed there are now two public methods only
|
@sebastiankb @Kaz040 are the revised public method names (see #7 (comment)) fine by you? |
> npx depcheck Unused devDependencies * typescript-standard Missing dependencies * wot-thing-description-types: .\src\asset-interfaces-description.ts
@danielpeintner , The names are ok for me. |
its perfect for me. ready for merge |
FYI: aas-aid package available on NPM (see https://www.npmjs.com/package/@thingweb/aas-aid) |
Guys, sorry for adding a comment here but I am not able to use/reach the transformTD2AAS function. Do you have any example of how to use it? is it already implemented? |
An example is given in the NPM readme of or can be found also at the new home. Note: the naming of the functions has been slightly changed (e.g., |
Mmmm I saw this comment: Do I need to use the createAAS parameter? We may need to update the documentation to reflect that approach. |
Yes, correct. As mentioned in the example td-tools/node/aas-aid/README.md Line 93 in ee21893
Do you think we should improve the documentation? |
I took over AID code from node-wot td-tools.
What is working:
npm run build
npm run test
TODOs/ To be decided
"1.0.0"
? see c7a66eatransformAAS2TD(...)
--> finetransformTD2AAS(...)
--> finetransformSM2TD(...)
--> not sure if "SM" for sub-model should be used, maybetransformAID2TD(...)
??transformTD2SM(...)
--> same as abovetransformAID2TD(aasAID: string, template?: string, submodelRegex?: string): string
transformTD2AID(td: string, options?: Options, protocols?: string[]): string
createAAS
can be passed to get a full AAS