-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove AID tooling #1256
Remove AID tooling #1256
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1256 +/- ##
==========================================
+ Coverage 76.62% 78.39% +1.76%
==========================================
Files 84 83 -1
Lines 17586 15929 -1657
Branches 1807 1595 -212
==========================================
- Hits 13475 12487 -988
+ Misses 4057 3417 -640
+ Partials 54 25 -29 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with the timeline, let's merge this when all the boxes are ticked.
I believe the PR is now ready to be merged. All TODOs are done and a new aas-aid package has been pushed on NPM (see https://www.npmjs.com/package/@thingweb/aas-aid) |
Good! we can merge from my side as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the changed files as well and it looks good to me
TODOs before merging
Push new package on NPMaas-aid package available on NPM (see https://www.npmjs.com/package/@thingweb/aas-aid)Clean-up dependencies ?Looked into dependencies. Nothing to remove so far.fixes #1249