Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AID tooling #1256

Merged
merged 6 commits into from
Apr 11, 2024
Merged

Conversation

danielpeintner
Copy link
Member

@danielpeintner danielpeintner commented Mar 21, 2024

TODOs before merging

fixes #1249

@danielpeintner danielpeintner requested a review from relu91 as a code owner March 21, 2024 11:04
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.39%. Comparing base (2dc193e) to head (0ff34fa).
Report is 15 commits behind head on master.

❗ Current head 0ff34fa differs from pull request most recent head b0d851d. Consider uploading reports for the commit b0d851d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1256      +/-   ##
==========================================
+ Coverage   76.62%   78.39%   +1.76%     
==========================================
  Files          84       83       -1     
  Lines       17586    15929    -1657     
  Branches     1807     1595     -212     
==========================================
- Hits        13475    12487     -988     
+ Misses       4057     3417     -640     
+ Partials       54       25      -29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@relu91 relu91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with the timeline, let's merge this when all the boxes are ticked.

@danielpeintner
Copy link
Member Author

I believe the PR is now ready to be merged. All TODOs are done and a new aas-aid package has been pushed on NPM (see https://www.npmjs.com/package/@thingweb/aas-aid)

@relu91
Copy link
Member

relu91 commented Apr 11, 2024

Good! we can merge from my side as well.

Copy link
Member

@egekorkan egekorkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the changed files as well and it looks good to me

@egekorkan egekorkan merged commit d2d7833 into eclipse-thingweb:master Apr 11, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Moving AID tooling to td-tools repository
3 participants