Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugin: fix hosted-plugin dialog #9764

Merged
merged 1 commit into from
Jul 29, 2021
Merged

plugin: fix hosted-plugin dialog #9764

merged 1 commit into from
Jul 29, 2021

Conversation

vince-fugnitto
Copy link
Member

What it does

Fixes: #9763.

The pull-request fixes the hosted-plugin dialog when starting an instance for both the browser and electron targets by not directly using the dialog-factory and instead using the file-dialog-service.

How to test

  1. start the electron instance
  2. execute the command hosted plugin: start instance - the dialog should now open
  3. start the browser instance
  4. execute the command hosted plugin: start instance - the dialog should now open

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com

@vince-fugnitto
plugin: fix hosted-plugin dialog
0964c01 
The commit fixes the `hosted-plugin` dialog to make it operational in
both the `browser` and `electron` targets by not directly using the factory and
instead using the service.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
@vince-fugnitto vince-fugnitto added the plug-in system issues related to the plug-in system label Jul 22, 2021
@vince-fugnitto vince-fugnitto self-assigned this Jul 22, 2021
alvsan09
alvsan09 reviewed Jul 22, 2021
View reviewed changes
Copy link
Contributor

@alvsan09 alvsan09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that the dialog now appears both when using electron as well as in the browser 👍
I have not checked the actual functionality to successfully load the plugin, etc.. I assume this will be addressed in a different PR.

colin-grant-work
colin-grant-work approved these changes Jul 28, 2021
View reviewed changes
Copy link
Contributor

@colin-grant-work colin-grant-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see dialogs on both platforms. 👍

@vince-fugnitto vince-fugnitto merged commit 1b16fe8 into master Jul 29, 2021
@vince-fugnitto vince-fugnitto deleted the vf/fix-hosted-plugin-dialog branch July 29, 2021 14:23
@github-actions github-actions bot added this to the 1.16.0 milestone Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvsan09 alvsan09 alvsan09 left review comments

@colin-grant-work colin-grant-work colin-grant-work approved these changes

Assignees

@vince-fugnitto vince-fugnitto

Labels
plug-in system issues related to the plug-in system
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.

plugin: hosted-plugin dialog does not open
3 participants
@vince-fugnitto @colin-grant-work @alvsan09