Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin: add support for refreshFilesExplorer #9738

Merged
merged 1 commit into from
Jul 16, 2021

Conversation

vince-fugnitto
Copy link
Member

What it does

Fixes: #5885.

The commit adds support for the workbench.files.action.refreshFilesExplorer command on the plugin side
which delegates to the REFRESH_NAVIGATOR command.

How to test

  1. add vscode-refresh-explorer test plugin.
  2. on master the execution of the test: refresh explorer command will throw an error on the backend.
root ERROR [hosted-plugin: 21091] With stack trace: Error: Command with id 'workbench.files.action.refreshFilesExplorer' is not registered.
    at CommandRegistryMainImpl.<anonymous> (file:///home/evinfug/workspaces/theia/examples/electron/lib/packages_plugin-ext_lib_hosted_browser_hosted-plugin_js.bundle.js:3228:35)
    at step (file:///home/evinfug/workspaces/theia/examples/electron/lib/packages_plugin-ext_lib_hosted_browser_hosted-plugin_js.bundle.js:3138:23)
    at Object.next (file:///home/evinfug/workspaces/theia/examples/electron/lib/packages_plugin-ext_lib_hosted_browser_hosted-plugin_js.bundle.js:3119:53)
    at file:///home/evinfug/workspaces/theia/examples/electron/lib/packages_plugin-ext_lib_hosted_browser_hosted-plugin_js.bundle.js:3113:71
    at new Promise (<anonymous>)
  1. on the pull-request the execution of the test: refresh explorer command will successfully execute.

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com

The commit adds support for the
`workbench.files.action.refreshFilesExplorer` command on the plugin side
which delegates to the `REFRESH_NAVIGATOR` command.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
@vince-fugnitto vince-fugnitto added navigator issues related to the navigator/explorer vscode issues related to VSCode compatibility labels Jul 14, 2021
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that the issue exists on master and is addressed by this change nicely.

@vince-fugnitto vince-fugnitto merged commit 83259fb into master Jul 16, 2021
@vince-fugnitto vince-fugnitto deleted the vf/refreshFilesExplorer branch July 16, 2021 16:42
@github-actions github-actions bot added this to the 1.16.0 milestone Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
navigator issues related to the navigator/explorer vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[navigator] add refresh command and toolbar item
3 participants