Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[navigator] add refresh command and toolbar item #5885

Closed
tetchel opened this issue Aug 8, 2019 · 3 comments · Fixed by #9738
Closed

[navigator] add refresh command and toolbar item #5885

tetchel opened this issue Aug 8, 2019 · 3 comments · Fixed by #9738
Labels
enhancement issues that are enhancements to current functionality - nice to haves help wanted issues meant to be picked up, require help navigator issues related to the navigator/explorer vscode issues related to VSCode compatibility

Comments

@tetchel
Copy link
Contributor

tetchel commented Aug 8, 2019

The theia new-folder detection does not appear to be perfect - see eclipse-archived/codewind#67. I'd like to be able to manually refresh the Explorer from my extension.

In VS Code, I see the command workbench.files.action.refreshFilesExplorer. I suppose there should be an equivalent command in Theia, but perhaps there isn't yet because there is no refresh button in the Explorer view like there is in VS Code:
image

Currently we have to refresh the browser tab, which is not really an acceptable work around.

@akosyakov akosyakov added enhancement issues that are enhancements to current functionality - nice to haves navigator issues related to the navigator/explorer vscode issues related to VSCode compatibility labels Aug 8, 2019
@akosyakov akosyakov changed the title [question] Possible to manually refresh the Explorer view? [navgator] add refresh command and toolbar item Aug 8, 2019
@akosyakov akosyakov added the help wanted issues meant to be picked up, require help label Aug 8, 2019
@tetchel tetchel changed the title [navgator] add refresh command and toolbar item [navigator] add refresh command and toolbar item Aug 8, 2019
@akosyakov
Copy link
Member

It is up to grab. One can add a refresh command and toolbar item first, and then add workbench.files.action.refreshFilesExplorer command to the plugin system which delegates to the navigator command. It could be 2 separate PRs.

@vince-fugnitto
Copy link
Member

Closed in #5885

@akosyakov
Copy link
Member

akosyakov commented Aug 14, 2019

@kpge @vince-fugnitto We need to register workbench.files.action.refreshFilesExplore in the plugin system which delegates to navigator.refresh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement issues that are enhancements to current functionality - nice to haves help wanted issues meant to be picked up, require help navigator issues related to the navigator/explorer vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants