Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plug-in] 4084 show refs command #4338

Merged
merged 2 commits into from
Feb 26, 2019

Conversation

tsmaeder
Copy link
Contributor

Fixes #4084.

  1. Separates the "Command" objects used in the Theia plugin API for registration of commands and invocation of commands into two separate interfaces: CommandRegistration and Command. The "Command" interface is compatible with the related vscode API interface. The unnecessary fields in the separated interfaces have been made deprecated. They will be removed after a period of deprecation. The new code should be compatible with the old version.
  2. Introduces "KnownCommands" where well known command invocations can be mapped to other command ids and parameters can be converted.
  3. Removed "CommandConverter", as I don't think it is needed.

@benoitf benoitf changed the title 4084 show refs command [plug-in] 4084 show refs command Feb 14, 2019
@benoitf
Copy link
Contributor

benoitf commented Feb 14, 2019

maybe a comment on https://github.com/theia-ide/theia/blob/master/CHANGELOG.md in breaking changes (or deprecation notice)

@tsmaeder tsmaeder force-pushed the 4084_show_refs_command branch 2 times, most recently from b148bc9 to c5b598e Compare February 15, 2019 14:30
Signed-off-by: Thomas Mäder <tmader@redhat.com>
Signed-off-by: Thomas Mäder <tmader@redhat.com>
@tsmaeder tsmaeder merged commit 30eaeb0 into eclipse-theia:master Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants