Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plug-in]Delegate showReferences command to textEditor.commands.showReferences #4084

Closed
svor opened this issue Jan 16, 2019 · 3 comments
Closed
Assignees
Labels
plug-in system issues related to the plug-in system

Comments

@svor
Copy link
Contributor

svor commented Jan 16, 2019

The command to show references is already registered by id textEditor.commands.showReferences. But plugins know nothing about textEditor.commands.showReferences id, they use editor.action.showReferences to show references.

To make it possible to execute editor.action.showReferences from the plugin and don't break existing clients we need to delegate editor.action.showReferences to existing textEditor.commands.showReferences command in plugin-ext-vscode.

@svor svor added the plug-in system issues related to the plug-in system label Jan 16, 2019
@tsmaeder
Copy link
Contributor

The command is called, for example when executing the "references" code lens.

@tsmaeder
Copy link
Contributor

Actually, there seems to be a metric boatload of commands that are predefined in VS Code: https://code.visualstudio.com/api/references/commands

@benoitf
Copy link
Contributor

benoitf commented Jan 29, 2019

linking to #4050

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plug-in system issues related to the plug-in system
Projects
None yet
Development

No branches or pull requests

3 participants