Avoid changing context key view when changing selection #13768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsmaeder
reviewed
Jun 19, 2024
| @@ -197,7 +194,6 @@ export class TreeViewsMainImpl implements TreeViewsMain, Disposable { | |||
| })); | |||
|
|
|||
| this.toDispose.push(treeViewWidget.model.onSelectionChanged(event => { | |||
| this.contextKeys.view.set(treeViewId); | |||
There was a problem hiding this comment.
Would it make sense to remove the view context key? It never makes sense to set it in the global context, as I understand it.
There was a problem hiding this comment.
I removed this context key, as it indeed makes no sense on a global context. focusedView makes sense here, but not view.
rschnekenbu
force-pushed
the
issues/13375
branch
from
e43ebd5
to
95ecea5
Compare
fixes eclipse-theia#13375 contributed on behalf of STMicroelectronics Signed-off-by: Remi Schnekenburger <rschnekenburger@eclipsesource.com>
rschnekenbu
force-pushed
the
issues/13375
branch
from
95ecea5
to
29aea5b
Compare
|
Pushed a new version that removes view from the view context key, as it makes no sense in a global context. |
tsmaeder
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Closes #13375
In a tree view provided by an extension, refreshing the tree node selection was changing the context key view. This was changing the view in the root context. So when the actions in toolbar were refreshed, the "when" rule was always returning
truefor any view, not only the concerned one.Avoid changing the context key view should not be done on selection refresh in this case.
contributed on behalf of STMicroelectronics
How to test
Review checklist
Reminder for reviewers