-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NPM Support builtin extension: Issue in the Refresh toolbar command #13375
Comments
This could be related to the view/title menu contribution with this condition: "when": "view == npm" |
Are there any workarounds for this issue? I've tried multiple ways of rewriting "when" predicate, but it doesn't seem to work. |
@vnfedotov I assume this is a bug in the update logic of the toolbar renderer. I'm not aware of a workaround and I don't think there is one. Feel free to contribute a PR to fix the issue. |
fixes eclipse-theia#13375 contributed on behalf of STMicroelectronics Signed-off-by: Remi Schnekenburger <rschnekenburger@eclipsesource.com>
fixes eclipse-theia#13375 contributed on behalf of STMicroelectronics Signed-off-by: Remi Schnekenburger <rschnekenburger@eclipsesource.com>
@rschnekenbu to quote @msujew
and I tend to agree: why would setting the context key lead to the icons being added to the wrong view? |
Hmh...what I mean is this: the context key |
fixes eclipse-theia#13375 contributed on behalf of STMicroelectronics Signed-off-by: Remi Schnekenburger <rschnekenburger@eclipsesource.com> address review suggestion: remove view from context key service
fixes eclipse-theia#13375 contributed on behalf of STMicroelectronics Signed-off-by: Remi Schnekenburger <rschnekenburger@eclipsesource.com>
fixes #13375 contributed on behalf of STMicroelectronics Signed-off-by: Remi Schnekenburger <rschnekenburger@eclipsesource.com>
Bug Description:
Hi,
There is an issue in the builtin vscode NPM support extension, where the refresh command could be added to other tree components like the file explorer and the extensions list.
Steps to Reproduce:
Additional Information
The text was updated successfully, but these errors were encountered: