[RPC] Delay sending messages when there are handlers running initialization #13180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfaltermeier
force-pushed
the
jf/13172_proxyHandlerInit
branch
from
047e404
to
5d35e32
Compare
jfaltermeier
changed the title
* add an event to listen for init events on rpc proxy handler * eager initialize DOCUMENTS_EXT Proxy when EDITORS_AND_DOCUMENTS_EXT was initialized
* automate init by specifying required remote depednencies on set
* add other dependencies * make sure to not start initialization multiple times
jfaltermeier
force-pushed
the
jf/13172_proxyHandlerInit
branch
2 times, most recently
from
20cce47
to
276b7e7
Compare
* don't throw error on possible race condition but log only * initialize dependencies before resolving promise
jfaltermeier
force-pushed
the
jf/13172_proxyHandlerInit
branch
from
276b7e7
to
966d462
Compare
* revert previous approach
* pause communication during init of handlers * introduce init callback allowing to implement this blocking mechanism
* add debug logs
* remove debug logs again
* fix initial init promise state
jfaltermeier
changed the title
jfaltermeier
changed the title
|
@martin-fleck-at Could you please have another look? I've added an init callback that delays already initialized handlers from sending their messages immediately while an init is going on. As far as I could see, this should sync the messages/events as expected. |
|
@jfaltermeier Sure, I'll have another look at it tomorrow. |
martin-fleck-at
requested changes
Jan 12, 2024
* rename from init callback to proxy synchronizer * use rpc promise to report init done
jfaltermeier
force-pushed
the
jf/13172_proxyHandlerInit
branch
from
88eb199
to
437d1cc
Compare
martin-fleck-at
requested changes
Jan 15, 2024
* rename from init callback to proxy synchronizer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
With this PR
ClientProxyHandlers will report their init state. When there is a running initialization, we delay sending messages on all handlers until this initialization is done.This should prevent cases where messages sent later via an already initialized handler can overtake earlier messages that are waiting for their handler's initialization to finish.
This will help avoiding race condition like in #13172
Fixes #13158
Fixes #13172
Commits should be squashed when closing the PR
How to test
Follow-ups
Review checklist
Reminder for reviewers