Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'unknown document' error is thrown without mentioning what document is unknown #13158

Closed
jcortell68 opened this issue Dec 6, 2023 · 0 comments · Fixed by #13180
Closed

'unknown document' error is thrown without mentioning what document is unknown #13158

jcortell68 opened this issue Dec 6, 2023 · 0 comments · Fixed by #13180
Assignees
@jfaltermeier
Labels
quality issues related to code and application quality
Milestone
1.46.0

Comments

@jcortell68
Copy link
Contributor

Bug Description:

There are two places in document.ts where an Error is thrown saying a document is unknown, but the code isn't including the document URI string in the error. It sure would be helpful if it did.

Steps to Reproduce:

None needed. Self evident. The error condition isn't what's being reported here; I'm pointing out a deficiency in how the error is reported.
@jfaltermeier jfaltermeier self-assigned this Dec 11, 2023
jfaltermeier added a commit that referenced this issue Dec 14, 2023
@jfaltermeier
'unknown document' error is thrown without mentioning what document is
00e30c1 
unknown #13158
@jfaltermeier jfaltermeier mentioned this issue Dec 18, 2023
Merged
1 task
@msujew msujew added the quality issues related to code and application quality label Dec 20, 2023
jfaltermeier added a commit that referenced this issue Jan 3, 2024
@jfaltermeier
'unknown document' error is thrown without mentioning what document is
f640195 
unknown #13158
jfaltermeier added a commit that referenced this issue Jan 16, 2024
@jfaltermeier
[RPC] Delay sending messages when there are handlers running initiali…
6cd31cb 
…zation (#13180)

* 'unknown document' error is thrown without mentioning what document is unknown #13158
* pause communication during init of handlers #13172
* introduce synchronizer allowing to implement this blocking mechanism
@jfaltermeier jfaltermeier added this to the 1.46.0 milestone Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jfaltermeier jfaltermeier

Labels
quality issues related to code and application quality
Projects
None yet
Milestone
1.46.0
Development

Successfully merging a pull request may close this issue.

[RPC] Delay sending messages when there are handlers running initialization eclipse-theia/theia
3 participants
@msujew @jfaltermeier @jcortell68