-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create new untitled file when double clicking on the main area or tabbar #12867
Create new untitled file when double clicking on the main area or tabbar #12867
Conversation
… bar Signed-off-by: Christian Radke <c.radke@posteo.de>
An additional note: when the main editor window is in split mode and there's more than one tabbar, then the untitled document is always added to the last active tabbar, even if you double click on the empty space of another, non-active tabbar. IMHO it's a separate feature requirement to make the clicked-on tabbar active on the first click, unrelated to this feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @KR155E, thank you for your first contribution :)
Looking pretty good. I just have a minor comment regarding the event naming, see below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, looks good to me, thanks 👍
- update translation VSIXs to `1.81.0` - revert eclipse-theia/theia#12867 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
What it does
Fixes #8916
How to test
Double click on the empty area of the main dock panel when no widgets are opened or on the empty area of a tabbar. It should open a new untitled text file.
Review checklist
Reminder for reviewers